[fluent-bit] Add support for additional watch paths in hot reload #578
Conversation
danielkalotai
requested review from
edsiper,
naseemkullah and
stevehipwell
as code owners
Signed-off-by: Daniel Kalotai <daniel.kalotai@sap.com>
There was a problem hiding this comment.
Thanks for the PR @danielkalotai. I think a better API for this would be to add hotReload.extraWatchVolumes as a list of strings mapping to the extraVolumes. Then the hot reload could use a range $i $v : .Values.hotReload.extraWatchVolumes pattern to set the container args and volume mounts (mount to /watch/extra-<index>).
Signed-off-by: Daniel Kalotai <daniel.kalotai@sap.com>
There was a problem hiding this comment.
@danielkalotai thanks for the changes, please could you use this functionality in _ci/test-values.yaml` (it could just be an empty volume). Also please make sure you don't break the file line endings as has happened to Chart.yaml. And finally you'll need to bump the chart version of the tests will fail.
Signed-off-by: Daniel Kalotai <daniel.kalotai@sap.com>
Signed-off-by: Daniel Kalotai <daniel.kalotai@sap.com>
|
Not sure if I understood the eof correctly. |
Signed-off-by: Daniel Kalotai <daniel.kalotai@sap.com>
|
@danielkalotai your file should have a new line and use RE |
Signed-off-by: Daniel Kalotai <daniel.kalotai@sap.com>
Signed-off-by: Daniel Kalotai <daniel.kalotai@sap.com>
Signed-off-by: Daniel Kalotai <daniel.kalotai@sap.com>
Signed-off-by: Daniel Kalotai <daniel.kalotai@sap.com>
Signed-off-by: Daniel Kalotai <daniel.kalotai@sap.com>
fluent/fluent-bit#9718
It would be good to be able to define more paths which should be watched from the hot reload functionality.