Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding another userful apps #34

Closed
wants to merge 4 commits into from
Closed

adding another userful apps #34

wants to merge 4 commits into from

Conversation

linkmk
Copy link

@linkmk linkmk commented Oct 8, 2024

I just cloned HRMS code block to install another frappe apps like CRM, helpdesk and insights in this script.

@flexcomng
Copy link
Owner

Hi! @linkmk Thanks for the contribution. I will test this addition and merge once completed.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the repo name in the commit to the main?

@fthobe
Copy link

fthobe commented Nov 10, 2024

@flexcomng that would actually be a cool addition. Can I just make the correct pull request?

@flexcomng
Copy link
Owner

@flexcomng that would actually be a cool addition. Can I just make the correct pull request?

@fthobe yes please. I will close this pull request now so you can make the correct pull request.

@flexcomng flexcomng closed this Dec 4, 2024
@fthobe
Copy link

fthobe commented Dec 4, 2024

Have there been any significant changes we need to consider?

@flexcomng
Copy link
Owner

flexcomng commented Dec 4, 2024

No significant changes but i was considering moving additional app installs to after ssl install in case any app install breaks which is often the case with HRMS, the installation will still be deemed completed.

@fthobe
Copy link

fthobe commented Dec 4, 2024

@flexcomng done in PR #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants