-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differently localize electrodes with 3d scanner #939
base: master
Are you sure you want to change the base?
Differently localize electrodes with 3d scanner #939
Conversation
Adds the functionality to select the electrode position with only the middle mouse button. Instead to accidently clicking the left mouse button because one may want to use the matlab 3D rotate functionality. Other keys and their functionality remain the same.
Adds the functionality to select the electrode position with only the middle mouse button (can be modified for using only the right mouse button, there is a comment mentioning that) . Instead of accidently clicking the left mouse button because one may want to use the matlab 3D rotate functionality. Other keys and their functionality remain the same.
many computers (especially laptops) don't have a middle mouse button, so I don't think that is a good idea as default. Could you make a small test script that demonstrates it, starting from high-level functions (i.e. ft_electrodeplacement)? |
Yes, agreed, the middle mouse botton may not be the best solution therefore in the script there is an option to change this to the right mouse button. I think it is not ideal to click an electrode position just by trying to rotate the head model (easily done with the 3d rotate functionality), specially if hundreds of electrodes are involved where one would like to use this script. Please find the attached test script, it is the same from the tutorial - http://www.fieldtriptoolbox.org/tutorial/electrode/ The function ft_electrodeplacement calls the function ft_select_point3d where obviously the changes are made in this suggested commit. extra: For reference I attach another file sk_select_point3d, which is the changed ft_select_point3d file for checking the functionality. To do this line 170 in ft_electrodeplacement will need to be changed from ft_select_point3d to sk_select_point3d. |
maybe rotate if you left click and hold shift or ctrl or so? that is also a standard way to do so (but note my confusion about shift and ctrl, because some programs use the one, others the other one - so much for 'standard' way) |
That's a good point, perhaps the shift/ctrl key in addition to the left mouse click to rotate model is a better way; And just the left mouse click selects the electrode. |
Hi @saurabhsay what is the status of this? Do you know how to proceed based on @Horschig and @robertoostenveld 's inputs? |
Hi @schoffelen , I really like the idea from @Horschig , and it is easy enough to include this. I can edit and include this functionality in some time. p.s. |
The last ativity on this thread is already > 1.5 year ago. @SteixnerKumar what is the status of this. Has this been resolved for you, or is this easily resolvable? If not, I suggest to close the PR without merging. |
@schoffelen, Thanks for reaching out on this. It is resolved for windows and Linux systems that use the 3 button mouse (the merge request was open for this!). However not for the apple system. I am not currently working on this since I do not use the mac. @Horschig had the idea that will solve this for mac systems as well and would make it consistent over the different OS. |
When you select the elctrode positions manually it is time-comsuming to orient the head model to a desired view with just the keys 'w', 'a','s','d', hence I use the matlab figure window 3D rotate functionality. The problem is that when you want to rotate, the place where you point the mouse cursor gets selected as an electrode position. To avoid this I changed the code where the left mouse button does not select the electrode poisitions. The middle button is used for this purpose, but I have commented the line where the right mouse button can as well be configured to be used for this purpose.