Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix too strict option checking in the ft_inverse_ functions #2468

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

schoffelen
Copy link
Contributor

No description provided.

@schoffelen schoffelen self-assigned this Nov 26, 2024
Copy link

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_tutorial_beamformingextended, test_bug3078, test_tutorial_beamformer20120321, test_pull1377, test_pull1377b, test_tutorial_connectivity3, test_tutorial_meguk2015, test_bug1976, test_bug3029, test_bug3124, test_beamformer_sam, test_tutorial_beamformer20131122, inspect_ft_sourcemovie, test_shared_virtual_channels, test_bug1599, test_tutorial_coherence, test_bug2664, test_issue1198, test_tutorial_beamformingextended20131122, test_tutorial_beamformer, test_bug1563, test_ft_sourceanalysis

When inside the DCCN, please also consider testing: test_bug1298, test_bug2005, test_pull1456, test_bug1599, test_bug1746, test_bug2959, test_prepare_freq_matrices, test_pull1663, test_pull1377, test_beamformer_whitening, test_pull1377b, test_bug1563, test_tutorial_meguk2015, test_bug2399, test_bug2834, test_bug1049, test_bug3029

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

Copy link

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_tutorial_connectivity3, test_tutorial_meguk2015, test_ft_sourceanalysis, test_pull1377, test_tutorial_beamformer, test_tutorial_beamformingextended, test_issue1198, test_tutorial_beamformer20120321, test_bug1563, test_bug3029, test_bug1976, test_tutorial_beamformer20131122, test_shared_virtual_channels, test_pull1377b, test_tutorial_coherence, test_beamformer_sam, test_bug1599, test_tutorial_beamformingextended20131122, test_bug3078, inspect_ft_sourcemovie, test_bug2664, test_bug3124

When inside the DCCN, please also consider testing: test_pull1377b, test_bug1599, test_bug2399, test_bug1746, test_bug1563, test_bug2834, test_bug2005, test_tutorial_meguk2015, test_pull1456, test_beamformer_whitening, test_pull1663, test_pull1377, test_bug1049, test_prepare_freq_matrices, test_bug1298, test_bug3029, test_bug2959

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

@schoffelen
Copy link
Contributor Author

I think that this should do it, I checked the majority of the failing test functions (apart from the ones that only crashed after > 2 minutes.

@schoffelen schoffelen merged commit 0b14afa into fieldtrip:master Nov 26, 2024
2 checks passed
@schoffelen schoffelen deleted the checkconfig_source branch November 26, 2024 13:16
@robertoostenveld
Copy link
Member

Seems to have worked, this morning the dashboard did not report any errors. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strict option checking in inverse functions leads to dashboard failure
2 participants