Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: wrap underlying EtcdError error #18578

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

api: wrap underlying EtcdError error #18578

wants to merge 1 commit into from

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Sep 12, 2024

Without wrapping, using errors.Is() (or even trying to compare the error with ==) fails as EtcdError swallows the underlying error.

Related to #18493.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@ivanvc
api: wrap underlying EtcdError error
c837473 
Without wrapping, using `errors.Is()` (or even trying to compare the error with
`==`) fails as EtcdError swallows the underlying error.

Signed-off-by: Ivan Valdes <ivan@vald.es>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivanvc
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

@ivanvc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify c837473 link true /test pull-etcd-verify
pull-etcd-e2e-386 c837473 link true /test pull-etcd-e2e-386
pull-etcd-e2e-amd64 c837473 link true /test pull-etcd-e2e-amd64
pull-etcd-e2e-arm64 c837473 link true /test pull-etcd-e2e-arm64
pull-etcd-integration-4-cpu-amd64 c837473 link true /test pull-etcd-integration-4-cpu-amd64
pull-etcd-integration-2-cpu-amd64 c837473 link true /test pull-etcd-integration-2-cpu-amd64
pull-etcd-integration-1-cpu-amd64 c837473 link true /test pull-etcd-integration-1-cpu-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.08%. Comparing base (fdbde77) to head (edad785).
Report is 2 commits behind head on main.

❗ Current head edad785 differs from pull request most recent head c837473

Please upload reports for the commit c837473 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
api/v3rpc/rpctypes/error.go 82.60% <100.00%> (-7.87%) ⬇️

... and 87 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18578      +/-   ##
==========================================
- Coverage   68.77%   66.08%   -2.69%     
==========================================
  Files         420      420              
  Lines       35474    35476       +2     
==========================================
- Hits        24396    23445     -951     
- Misses       9656    10561     +905     
- Partials     1422     1470      +48

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdbde77...c837473. Read the comment docs.

@ivanvc ivanvc marked this pull request as draft September 12, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress size/S
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanvc @k8s-ci-robot @codecov-commenter