feat: unflag TypeScript config files #19266
Merged
+86
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cli
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fasttime
added
the
accepted
aladdin-add
reviewed
Dec 24, 2024
| @@ -335,6 +335,15 @@ describe("ESLint", () => { | |||
|
|
|||
| processStub.restore(); | |||
| }); | |||
|
|
|||
| it("should throw an error if the flag 'unstable_ts_config' is used", () => { | |||
There was a problem hiding this comment.
[question]: Is it more reasonable to regard it as a warning?
There was a problem hiding this comment.
Inactive flags would raise a warning before #18705 but now they throw errors because that makes it easier to track down problems. The drawback is that users will have to remove the flag for ESLint to keep working after the next update.
mdjermanovic
approved these changes
Dec 25, 2024
aladdin-add
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[X] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This PR marks support for TypeScript config files as a stable feature as discussed in the 2024-12-12 TSC meeting.
.ts,.mtsand.ctsextensions.ts_config_lookupwas moved to inactive.Is there anything you'd like reviewers to focus on?