Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] Bump content-tag to v3 #10599

Merged
merged 1 commit into from
Jan 3, 2025
Merged

[INTERNAL] Bump content-tag to v3 #10599

merged 1 commit into from
Jan 3, 2025

Conversation

SergeAstapov
Copy link
Contributor

@SergeAstapov SergeAstapov commented Jan 1, 2025 •
edited
Loading

@bertdeblock bertdeblock added dependencies Pull requests that update a dependency file internal labels Jan 2, 2025
@bertdeblock bertdeblock changed the title Bump content-tag to v3 [INTERNAL] Bump content-tag to v3 Jan 2, 2025
@bertdeblock
Copy link
Member

bertdeblock commented Jan 2, 2025 •
edited
Loading

@SergeAstapov Thanks! I think you also need to take this PR into account. The return type changed.

Sorry! I'm flippin it seems. Just need to check why CI is failing.

@SergeAstapov
Copy link
Contributor Author

@bertdeblock yeap, was thinking it's one line change but appears it's not - will debug why it's failing

bertdeblock
bertdeblock reviewed Jan 2, 2025
View reviewed changes
lib/models/blueprint.js Outdated Show resolved Hide resolved
@bertdeblock bertdeblock merged commit bafaac6 into ember-cli:master Jan 3, 2025
69 checks passed
@SergeAstapov SergeAstapov deleted the bump-content-tag branch January 3, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertdeblock bertdeblock bertdeblock approved these changes

@NullVoxPopuli NullVoxPopuli Awaiting requested review from NullVoxPopuli

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeAstapov @bertdeblock