Optimize client by opening transport to host once (#70)

dsg-uwaterloo · Dec 28, 2023 · a71be05 · a71be05
1 parent bd7cbea
commit a71be05
Showing 1 changed file with 18 additions and 16 deletions.
diff --git a/src/client/SharedQueue.h b/src/client/SharedQueue.h
@@ -86,20 +86,22 @@ class WarmUpRunner {
     WarmUpRunner(SharedQueue& sharedQueue): sharedQueue(sharedQueue) {}
 
     void operator()() {
+        auto socket = std::make_shared<TSocket>(HOST_IP, HOST_PORT);
+        auto transport = std::make_shared<TBufferedTransport>(socket);
+        auto protocol = std::make_shared<TBinaryProtocol>(transport);
+        RPCClient client(protocol);
+
+        transport->open();
+
         while (warmupOperations--) {
             Operation data = sharedQueue.dequeue();
             if (data.op == OpType::EOD) return;
 
-            auto socket = std::make_shared<TSocket>(HOST_IP, HOST_PORT);
-            auto transport = std::make_shared<TBufferedTransport>(socket);
-            auto protocol = std::make_shared<TBinaryProtocol>(transport);
-            RPCClient client(protocol);
-
-            transport->open();
             std::string out;
             client.access(out, data);
-            transport->close();
         }
+
+        transport->close();
     }
 };
 
@@ -113,26 +115,26 @@ class ClientRunner {
         sharedQueue(sharedQueue), latencies(latencies) {}
 
     void operator()() {
+        auto socket = std::make_shared<TSocket>(HOST_IP, HOST_PORT);
+        auto transport = std::make_shared<TBufferedTransport>(socket);
+        auto protocol = std::make_shared<TBinaryProtocol>(transport);
+        RPCClient client(protocol);
+
+        transport->open();
+
         while (true) {
             Operation data = sharedQueue.dequeue();
             if (data.op == OpType::EOD) return;
 
-            auto socket = std::make_shared<TSocket>(HOST_IP, HOST_PORT);
-            auto transport = std::make_shared<TBufferedTransport>(socket);
-            auto protocol = std::make_shared<TBinaryProtocol>(transport);
-            RPCClient client(protocol);
-
-            transport->open();
-
             auto start = high_resolution_clock::now();
             std::string out;
             client.access(out, data);
             auto end = high_resolution_clock::now();
             latencies.push_back(
                 duration_cast<milliseconds>(end - start).count());
-
-            transport->close();
         }
+
+        transport->close();
     }
 };