Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF for Aqara Smart plug (lumi.plug.maeu01) v45 #7976

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bluemoehre
Copy link
Contributor

From v45 Aqara removed current & voltage reporting, so we need a new DDF for that version only.

Copy link
Contributor

Hey @bluemoehre, thanks for your pull request!

Tip

Modified bundles can be downloaded here.
Relative expire date

DDB changes

Modified

  • xiaomi/xiaomi_sp-euc01_smart_plug.v45.json : Smart plug (SP-EUC01) ✔️

Validation

Tip

Everything is fine !

🕒 Updated for commit 23d142c

Copy link
Collaborator

@SwoopX SwoopX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this DDF will affect the vast majority and potentially break the power measurement capabilities altogether. Also, the cluster/attribute combination for the measurement sensors is not the right one.

Based on that, I cannot support the anticipated change.

@bluemoehre
Copy link
Contributor Author

I'm afraid this DDF will affect the vast majority and potentially break the power measurement capabilities altogether.

To not affect < v45 we added the Regexp, since the previous versions have the other clusters available. All tests so far have been okay locally. But I agree it would be more solid to match against the exact version (lets say v45+). Is there a way to achieve this - or - any other recommendation to pin a version?

Also, the cluster/attribute combination for the measurement sensors is not the right one.

Can you tell us the correct one so that we can update it? Thanks!

@SwoopX
Copy link
Collaborator

SwoopX commented Oct 27, 2024

Hi,

to pin a DDF depending on a device firmware version, please have a look at this PR: #7642 Haven't done it myself so far, so I can't share any experience.

Regarding the cluster/attribute combination, the correct ones are in the already existing DDF (power and consumption: 0x000C/0x0055, voltage and current comes via Xiaomi special attribte reporting).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants