Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#34420 Fix booelan settings #35615

Merged
merged 3 commits into from
Sep 23, 2024
Merged

#34420 Fix booelan settings #35615

merged 3 commits into from
Sep 23, 2024

Conversation

ivgag
Copy link
Contributor

@ivgag ivgag commented Sep 16, 2024

No description provided.

@ivgag ivgag linked an issue Sep 16, 2024 that may be closed by this pull request
@ivgag ivgag requested a review from E1izabeth September 17, 2024 09:10
@Matvey16
Copy link
Member

This bug still persists if an option with icons is saved. After that changing to text is impossible without manually changing every option
STR

  1. Change the display to icons
  2. Apply setting and close
  3. Try changing to text
dbeaver_DffsoFq7vx.mp4

@ivgag ivgag force-pushed the 34420-fix-boolean-settings branch from a1a418b to 72faadb Compare September 17, 2024 14:44
@Matvey16
Copy link
Member

But now opening settings overrides previous settings

  1. Change the text for boolean values
  2. Open preferences again and press apply without changing anything
dbeaver_zGX14nKvCD.mp4

@ivgag ivgag force-pushed the 34420-fix-boolean-settings branch from 72faadb to bf33c65 Compare September 17, 2024 21:44
@Matvey16
Copy link
Member

Verified

@serge-rider serge-rider merged commit 75fac60 into devel Sep 23, 2024
2 of 5 checks passed
@serge-rider serge-rider deleted the 34420-fix-boolean-settings branch September 27, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Booleans settings UX is too complex
5 participants