Cb 5440 merge into internal db #35594
Open
+306
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LonwoLonwo
reviewed
Sep 16, 2024
plugins/org.jkiss.dbeaver.db.internal/src/org/jkiss/dbeaver/db.internal/InternalDB.java
Outdated
Show resolved
Hide resolved
plugins/org.jkiss.dbeaver.db.internal/src/org/jkiss/dbeaver/db.internal/InternalDB.java
Show resolved
Hide resolved
plugins/org.jkiss.dbeaver.db.internal/src/org/jkiss/dbeaver/db.internal/InternalDB.java
Outdated
Show resolved
Hide resolved
serge-rider
requested changes
Dec 14, 2024
| import java.util.Properties; | ||
| import java.util.function.Function; | ||
|
|
||
| public abstract class InternalDB { |
There was a problem hiding this comment.
I don't really like idea to add apache dbcp dependency into dbeaver. I'd prefer to remove it from dbeaver-ee instead. We should use java.sql.DataSource wherever possible.
I don't like bundle name also. We can keep this code in o.j.d.model.jdbc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.