Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared channel handling #22

Open
cujomalainey opened this issue Oct 13, 2019 · 0 comments
Open

Add shared channel handling #22

cujomalainey opened this issue Oct 13, 2019 · 0 comments

Comments

@cujomalainey
Copy link
Owner

with the addition of transmission type bit field data. Channels can automatically identify if the channel is a shared channel. Certain profiles (bike lights) use shared channels. This re-arranges the order of the first 2 to 3 bytes depending on the mode. This change should be transparent to the user.

One of two solutions exist. One is to add this into the BaseDataPage(Msg) but then all profiles have to carry the burden of using this additional check when accessing data.

An alternative is to extend the BaseDataPage into a "shareable" datapage which implements the additional logic so the marginal overhead of one additional check is not seen by other profiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant