-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming/BlockParameterName + stdlib methods like sort #453
Comments
We could add those to the exclusion list. |
Yes please. And also: l, m, n and z :) |
This rule is causing confusion and I don't think it's very helpful. Can it be disabled by default? Related: https://forum.crystal-lang.org/t/ameba-warning-i-dont-understand/6377 |
Disabling it by default is a viable option, let's do that. |
Hello - today, ameba complains for usage one-letter block parameter names in the stdlib sort method usage.
But even in the Crystal docs, there is example with exact that short block parameter names:
https://crystal-lang.org/api/1.11.2/Array.html#sort%28%26block%3AT%2CT-%3EU%29%3AArray%28T%29forallU-instance-method
How would you imagine more descriptive block parameter names when using the sort method? "a" and "b" are optimal.
Thanks!
The text was updated successfully, but these errors were encountered: