Fix privilege dropping when setting process ownership

`os.setgid()` should be called to set the GID, and it should be called before `os.setuid()` to prevent reinstatement of privileges.
compubacter · Oct 31, 2019 · d08c3f7 · d08c3f7
1 parent 40ebdf3
commit d08c3f7
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/deluge/argparserbase.py b/deluge/argparserbase.py
@@ -329,18 +329,18 @@ def _handle_ui_options(self, options):
                     _file.write('%d\n' % os.getpid())
 
             if not common.windows_check():
+                if options.group:
+                    if not options.group.isdigit():
+                        import grp
+
+                        options.group = grp.getgrnam(options.group)[2]
+                    os.setgid(options.group)
                 if options.user:
                     if not options.user.isdigit():
                         import pwd
 
                         options.user = pwd.getpwnam(options.user)[2]
                     os.setuid(options.user)
-                if options.group:
-                    if not options.group.isdigit():
-                        import grp
-
-                        options.group = grp.getgrnam(options.group)[2]
-                    os.setuid(options.group)
 
         return options