Add some time saving comments to cf permissions checker (#4508)

cloudfoundry · Aug 20, 2020 · d27a12d · d27a12d
1 parent ad64761
commit d27a12d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/frontend/packages/cloud-foundry/src/user-permissions/cf-user-permissions-checkers.ts b/src/frontend/packages/cloud-foundry/src/user-permissions/cf-user-permissions-checkers.ts
@@ -191,7 +191,9 @@ export class CfUserPermissionsChecker extends BaseCurrentUserPermissionsChecker
     endpointGuid?: string,
     orgOrSpaceGuid?: string,
     allSpacesWithinOrg = false
-  ) {
+  ): Observable<boolean> {
+    // In some situations the observable returned here is not subscribed to (for example due to applyAdminCheck).
+    // This is bad (we should skip this function entirely) and should be fixed. This would require a thorough appraisal and overhaul.
     if (type === CfPermissionTypes.ENDPOINT_SCOPE) {
       if (!endpointGuid) {
         return of(false);
@@ -357,6 +359,7 @@ export class CfUserPermissionsChecker extends BaseCurrentUserPermissionsChecker
           return of(true);
         }
         if (isReadOnly) {
+          // This is bad, we should not assume that the check type wants a negative result if the user only has 'read only' rights.
           return of(false);
         }
         return check$;