Fixed todos

cloudfoundry · Jan 9, 2018 · 5dc32d2 · 5dc32d2
1 parent c3d5c43
commit 5dc32d2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/src/app/shared/components/list/list.component.ts b/src/app/shared/components/list/list.component.ts
@@ -142,8 +142,7 @@ export class ListComponent<T> implements OnInit, OnDestroy, AfterViewInit {
 
     this.paginationController = new ListPaginationController(this._store, this.dataSource);
 
-    // TODO: This should be configurable per list
-    this.paginator.pageSizeOptions = [5, 10, 20];
+    this.paginator.pageSizeOptions = this.listConfigService.pageSizeOptions;
     const paginationStoreToWidget = this.paginationController.pagination$.do((pagination: ListPagination) => {
       this.paginator.length = pagination.totalResults;
       this.paginator.pageIndex = pagination.pageIndex - 1;

diff --git a/src/app/shared/data-sources/list-data-source.ts b/src/app/shared/data-sources/list-data-source.ts
@@ -37,7 +37,7 @@ export abstract class ListDataSource<T, A = T> extends DataSource<T> implements
   public page$: Observable<T[]>;
 
   // Store related
-  public entityKey: string; // TODO: RC Needed?
+  public entityKey: string;
 
   // Add item
   public addItem: T;
@@ -85,7 +85,6 @@ export abstract class ListDataSource<T, A = T> extends DataSource<T> implements
       action: this.action,
       schema: [this.sourceScheme]
     },
-      null,
       isLocal
     );
 

diff --git a/src/app/store/reducers/pagination-reducer/pagination-reducer.helper.ts b/src/app/store/reducers/pagination-reducer/pagination-reducer.helper.ts
@@ -87,7 +87,6 @@ export function getPaginationKey(action: PaginatedAction) {
 
 export const getPaginationObservables = <T = any>(
   { store, action, schema }: { store: Store<AppState>, action: PaginatedAction, schema: Schema },
-  uid?: string, // TODO: Delete me?
   isLocal = false
 ): PaginationObservables<T> => {
   const { entityKey, paginationKey } = action;