Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix row count asset check for vcerare #3993

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Fix row count asset check for vcerare #3993

merged 4 commits into from
Dec 20, 2024

Conversation

zschira
Copy link
Member

@zschira zschira commented Dec 19, 2024

Overview

This PR fixes the VCERARE row count asset_check. This check was using the expected row count for the full ETL, and would fail for the fast ETL. Now it handles both correctly.

@zschira zschira requested a review from jdangerx December 19, 2024 22:46
@zschira zschira self-assigned this Dec 19, 2024
jdangerx
jdangerx approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@jdangerx jdangerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you!

Also tiny typo fix. But otherwise good to go!

src/pudl/transform/vcerare.py Outdated Show resolved Hide resolved
src/pudl/transform/vcerare.py Outdated Show resolved Hide resolved
@jdangerx jdangerx changed the base branch from main to 3928-asset-checks-run-again December 19, 2024 22:49
@jdangerx jdangerx changed the base branch from 3928-asset-checks-run-again to main December 19, 2024 22:49
zschira and others added 2 commits December 19, 2024 17:49
@zschira @jdangerx
Fix typo
9015db7 
Co-authored-by: Dazhong Xia <dazhong.xia@catalyst.coop>
@zschira @jdangerx
Fix typo
c97e5a4 
Co-authored-by: Dazhong Xia <dazhong.xia@catalyst.coop>
@zschira
Copy link
Member Author

zschira commented Dec 19, 2024

lol expectedededed

@zschira zschira enabled auto-merge December 19, 2024 22:50
@zschira zschira added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit d6e385c Dec 20, 2024
17 checks passed
@zschira zschira deleted the fix_vce_row_count branch December 20, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdangerx jdangerx jdangerx approved these changes

Assignees

@zschira zschira

Labels
None yet
Projects
Catalyst Megaproject
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zschira @jdangerx