Add HttpErrorCodeInterface. #18110
Add HttpErrorCodeInterface. #18110
Conversation
ADmad
force-pushed
the
feat/5.2-http-exception-interface
branch
2 times, most recently
from
e740154 to
de5e52a
Compare
|
|
||
| use Throwable; | ||
|
|
||
| interface HttpErrorCodeInterface extends Throwable |
There was a problem hiding this comment.
Ideally this should have been in the Http package but couple of exceptions of the Datasource package are also mapped to 404 code :/
There was a problem hiding this comment.
I think this is ok. Hard to create a generic map with one way dependencies with our split packages.
There was a problem hiding this comment.
Do we get much from extending Throwable?
There was a problem hiding this comment.
Not really, I did it as this interface is only meant to be used by exception classes.
|
The static analysis job failure is because the composer.json of split packages use cakephp 5.1. |
|
We should be using dev branches I guess |
ADmad
force-pushed
the
feat/5.2-http-exception-interface
branch
from
de5e52a to
3e97a14
Compare
Even that doesn't help, since the new interface file is in this PR. The error will be gone only after the PR is merged. |
| * @var array<string, int> | ||
| * @psalm-var array<class-string<\Throwable>, int> | ||
| */ | ||
| protected array $exceptionHttpCodes = [ |
There was a problem hiding this comment.
We could end up breaking userland exception rendering with this change. If we wanted to avoid the breakage, we could retain this as an empty list and also retain line 408 as a fallback for exceptions that don't implement HttpErrorCodeInterface
There was a problem hiding this comment.
Okay, I'll add it back for BC.
|
|
||
| use Throwable; | ||
|
|
||
| interface HttpErrorCodeInterface extends Throwable |
There was a problem hiding this comment.
Do we get much from extending Throwable?
ADmad
force-pushed
the
feat/5.2-http-exception-interface
branch
from
3e97a14 to
1e2087f
Compare
Using this interface allows exception classes to indicate that they use HTTP error codes and avoid having to maintain an error class to HTTP error code map in WebExceptionRenderer.
ADmad
force-pushed
the
feat/5.2-http-exception-interface
branch
from
1e2087f to
d5d72da
Compare
|
Looks good to me. The split package phpstan builds are failling. Those builds might clear up after we do a release though. |
Using this interface allows exception classes to indicate that they use HTTP error codes and avoid having to maintain an error class to HTTP error code map in WebExceptionRenderer.