Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TableEventsTrait only #18044

Open
wants to merge 6 commits into
base: 5.next
Choose a base branch
from
Open

Add TableEventsTrait only #18044

wants to merge 6 commits into from

Conversation

bancer
Copy link
Contributor

@bancer bancer commented Nov 29, 2024

See #18008.

@bancer bancer marked this pull request as ready for review November 29, 2024 12:18
@ADmad ADmad changed the base branch from 5.x to 5.next November 29, 2024 12:50
@dereuromark dereuromark added this to the 5.2.0 milestone Nov 29, 2024
ADmad
ADmad reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@ADmad ADmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs test coverage.

src/ORM/TableEventsTrait.php Outdated Show resolved Hide resolved
src/ORM/TableEventsTrait.php Outdated Show resolved Hide resolved
src/ORM/TableEventsTrait.php Outdated Show resolved Hide resolved
@ADmad ADmad requested a review from markstory November 29, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADmad ADmad ADmad left review comments

@dereuromark dereuromark dereuromark approved these changes

@markstory markstory Awaiting requested review from markstory

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bancer @dereuromark @ADmad @LordSimal @othercorey