Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing dep esbuild on init #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jycouet
Copy link

@jycouet jycouet commented Nov 30, 2023

No description provided.

Copy link

@WesleyKapow WesleyKapow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add esbuild manually. This would have saved me that debug step.

@terryaney
Copy link

@WesleyKapow

What do you mean by this?

I had to add esbuild manually. This would have saved me that debug step.

This enables 'debugging' the index.ts files?

@jycouet
Copy link
Author

jycouet commented Jan 3, 2024

If your run the setup and select typescript, you NEED esbuild, if not, the runner will not run.

So today, each people running the setup selecting typescript need to find out that there is a missing dep: esbuild.

This PR fix this. (not related to debugging.)

@terryaney
Copy link

Interesting. I am running Typescript and runner works fine. Here is my package.json:

image

@jycouet
Copy link
Author

jycouet commented Jan 4, 2024

You probably have typescript & esbuild installed globally?

@terryaney
Copy link

Yeah, must have. I have other 'real' typescript projects. And my son started messing with AOC and we needed to do exactly this :) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants