Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing package filtering sends a silent notification #352

Open
buresdv opened this issue Jun 20, 2024 · 0 comments
Open

Changing package filtering sends a silent notification #352

buresdv opened this issue Jun 20, 2024 · 0 comments
Labels
Bug Something isn't working

Comments

@buresdv
Copy link
Owner

buresdv commented Jun 20, 2024

When the user changes the package filtering option in the settings, Cork send a "new updates available" notification, due to the notification system being tied to changes in the number of displayable updatable packages. This notificaiton doesn't get shown, since the app is in the foreground.

Code responsible:

Cork/Cork/CorkApp.swift

Line 220 in 698f9d6

.onChange(of: outdatedPackageTracker.displayableOutdatedPackages.count)

Cork/Cork/CorkApp.swift

Line 245 in 698f9d6

if sendStandardUpdatesAvailableNotification

Fix once macOs 15 comes out to take it in line with the new concurrency system.
@buresdv buresdv added the Bug Something isn't working label Jun 20, 2024
@buresdv buresdv moved this from Ideas to Bugs in Cork Project Board Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
Cork Project Board
Status: Bugs
Milestone
No milestone
Development

No branches or pull requests
1 participant
@buresdv