Don't apply monkey patches on generic start #8278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lephilousophe
force-pushed
the
no-monkeypatch
branch
from
8cce1a6 to
5d41ee0
Compare
|
I think it would make sense to bring back |
lephilousophe
force-pushed
the
no-monkeypatch
branch
from
5d41ee0 to
0a07395
Compare
|
Done. |
p12tic
approved these changes
Jan 12, 2025
Since commit d6b698e, the monkey patches were applied on every installs. This implies that set_is_in_unit_tests(True) was called even when not it in unit tests. Because it believes being in tests, db.logs._async_iter_on_pool is importing NonThreadPool from a submodule in the test module. This runs the test __init__ code which sets up warnings as error by default. As a consequence, any Deprecation warning will trigger an exception instead of just being shown in logs. This is causing troubles in current v4.2.0 with out of tree modules (which use deprecated code, granted). This partially reverts commit d6b698e. In addition, some patches are always run and some only during tests. Modified-by: Povilas Kanapickas <povilas@radix.lt>
p12tic
force-pushed
the
no-monkeypatch
branch
from
0a07395 to
a894300
Compare
|
I added release note and also copied PR description to the commit comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit d6b698e, the monkey patches were applied on every installs.
This implies that set_is_in_unit_tests(True) was called even when not it in unit tests.
Because it believes being in tests, db.logs._async_iter_on_pool is importing NonThreadPool
from a submodule in the test module.
This runs the test init code which sets up warnings as error by default.
As a consequence, any Deprecation warning will trigger an exception
instead of just being shown in logs.
This is causing troubles in current v4.2.0 with out of tree modules (which use deprecated code, granted).
A backport would be great.
Contributor Checklist:
newsfragmentsdirectory (and read theREADME.txtin that directory)