Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safe unwrap #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

safe unwrap #50

wants to merge 1 commit into from

Conversation

007gzs
Copy link

@007gzs 007gzs commented Sep 3, 2024

No description provided.

@bspeice
Copy link
Owner

bspeice commented Sep 3, 2024

It seems like this is mostly a reformatting commit, along with a couple changes so that some unwrap calls become a Result instead? I'm happy to accept a pull request for one or the other, but it's difficult to understand what functionally changed when most of the lines are formatting. Please also include unit tests to demonstrate the behavior change, rather than just the unwrap tweaks.

@007gzs
Copy link
Author

007gzs commented Sep 4, 2024

I accepted the modification suggestions from cargo fmt and cargo clippy before submitting. So it caused a lot of formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants