Cosmetic changes

bluemir · May 9, 2015 · d6771dc · d6771dc
1 parent b690611
commit d6771dc
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 17 deletions.
diff --git a/context.go b/context.go
@@ -184,25 +184,22 @@ func (c *Context) ParamValue(key string) (va string) {
 func (c *Context) DefaultPostFormValue(key, defaultValue string) string {
 	if va, ok := c.postFormValue(key); ok {
 		return va
-	} else {
-		return defaultValue
 	}
+	return defaultValue
 }
 
 func (c *Context) DefaultFormValue(key, defaultValue string) string {
 	if va, ok := c.formValue(key); ok {
 		return va
-	} else {
-		return defaultValue
 	}
+	return defaultValue
 }
 
 func (c *Context) DefaultParamValue(key, defaultValue string) string {
 	if va, ok := c.paramValue(key); ok {
 		return va
-	} else {
-		return defaultValue
 	}
+	return defaultValue
 }
 
 func (c *Context) paramValue(key string) (string, bool) {

diff --git a/logger.go b/logger.go
@@ -75,32 +75,32 @@ func LoggerWithFile(out io.Writer) HandlerFunc {
 
 func colorForStatus(code int) string {
 	switch {
-	case code >= 200 && code <= 299:
+	case code >= 200 && code < 300:
 		return green
-	case code >= 300 && code <= 399:
+	case code >= 300 && code < 400:
 		return white
-	case code >= 400 && code <= 499:
+	case code >= 400 && code < 500:
 		return yellow
 	default:
 		return red
 	}
 }
 
 func colorForMethod(method string) string {
-	switch {
-	case method == "GET":
+	switch method {
+	case "GET":
 		return blue
-	case method == "POST":
+	case "POST":
 		return cyan
-	case method == "PUT":
+	case "PUT":
 		return yellow
-	case method == "DELETE":
+	case "DELETE":
 		return red
-	case method == "PATCH":
+	case "PATCH":
 		return green
-	case method == "HEAD":
+	case "HEAD":
 		return magenta
-	case method == "OPTIONS":
+	case "OPTIONS":
 		return white
 	default:
 		return reset

diff --git a/render/render_test.go b/render/render_test.go
@@ -13,6 +13,9 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+// TODO unit tests
+// test errors
+
 func TestRenderJSON(t *testing.T) {
 	w := httptest.NewRecorder()
 	w2 := httptest.NewRecorder()