PT Use Weights #58
Merged
PT Use Weights #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
okay testing this out we have good news and bad news good news: the bike-only route matches the route from the bike2 endpoint, and it's pretty good! nice to see usable bike routes in bikehopper pt endpoint: bad news: something broke and it's not getting onto public transit at the right time. also it's doing random small trips for reasons i'm not sure about. will have to dig into this tomorrow, bet it's something with |
hcourt
reviewed
Apr 14, 2022
reader-gtfs/src/main/java/com/graphhopper/gtfs/PtWeighting.java
Outdated
Show resolved
Hide resolved
This was referenced Apr 14, 2022
hcourt
reviewed
Apr 19, 2022
core/src/main/java/com/graphhopper/routing/weighting/FastestWeighting.java
Outdated
Show resolved
Hide resolved
hcourt
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
Fixes #47
Fixes #48
changes:
Labelshave anedgeWeightthat is incremented as used to check dominationPtEdges are now converted into weights usingPtWeighting. for now this is a simple multiplier but maybe we could do something more sophisticatedTODO: