ENH Download plots as PDF in the html (for now only SVG) #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 82.27% 82.27%
=======================================
Files 46 46
Lines 3171 3171
=======================================
Hits 2609 2609
Misses 562 562 |
tomMoral
reviewed
Nov 28, 2024
|
|
||
| Plotly.downloadImage(plot, | ||
| {format: 'svg', | ||
| // filename is the name of the solver used |
There was a problem hiding this comment.
Yes not the solver, but the objective, the metric and the chart type.
Here is the screenshot of the page
And this is the svg result
There was a problem hiding this comment.
why is it a svg? it shoud be a pdf :) or change the name of the feature.
There was a problem hiding this comment.
It is an svg because I couldn't convert it yet to pdf like I said in my first comment. It is still a work in progress.
Jad-yehya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to add the functionality described in issue #767
Added a PDF button in the html to download the plot in pdf. For now it is only possible to download the plot as an SVG.
I added the
exportPDFfunction that utilizes Plotly directly by calling thedownloadImagemethod.Next step would be to convert the svg to pdf directly in the
exportPDF. An attempt has been unsuccesful usingjsPDF.