Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize CatalogTable #28449

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Harmonize CatalogTable #28449

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d563f05
Harmonize `CatalogTable`
Andy2003 Jan 13, 2025
018677a
fix api-reports (why ever they changed?)
Andy2003 Jan 13, 2025
931d4f8
distinguish between client and server side paging
Andy2003 Jan 17, 2025
cdcebb7
use paging mode from context
Andy2003 Jan 17, 2025
5b3a95c
clean up code
Andy2003 Jan 17, 2025
23fea14
fix tests
Andy2003 Jan 17, 2025
0a9fc5d
Merge remote-tracking branch 'origin/master' into bugfix/harmonize-ca…
Andy2003 Jan 17, 2025
5024624
optimize code
Andy2003 Jan 17, 2025
245c55c
do always show paging bar, so the user can change the limit even if t…
Andy2003 Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/funny-papayas-tell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@backstage/plugin-catalog': minor
---

Harmonize `CatalogTable`

- Show pagination text for `OffsetPagination`
- Use same `OffsetPaginatedCatalogTable` also as fallback if no pagination is set
- Do not show paging if there is only one page
42 changes: 21 additions & 21 deletions plugins/app-visualizer/report.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,27 @@ const visualizerPlugin: FrontendPlugin<
{},
{},
{
'nav-item:app-visualizer': ExtensionDefinition<{
kind: 'nav-item';
name: undefined;
config: {};
configInput: {};
output: ConfigurableExtensionDataRef<
{
title: string;
icon: IconComponent;
routeRef: RouteRef<undefined>;
},
'core.nav-item.target',
{}
>;
inputs: {};
params: {
title: string;
icon: IconComponent;
routeRef: RouteRef<undefined>;
};
}>;
'page:app-visualizer': ExtensionDefinition<{
kind: 'page';
name: undefined;
Expand Down Expand Up @@ -46,27 +67,6 @@ const visualizerPlugin: FrontendPlugin<
routeRef?: RouteRef<AnyRouteRefParams> | undefined;
};
}>;
'nav-item:app-visualizer': ExtensionDefinition<{
kind: 'nav-item';
name: undefined;
config: {};
configInput: {};
output: ConfigurableExtensionDataRef<
{
title: string;
icon: IconComponent;
routeRef: RouteRef<undefined>;
},
'core.nav-item.target',
{}
>;
inputs: {};
params: {
title: string;
icon: IconComponent;
routeRef: RouteRef<undefined>;
};
}>;
}
>;
export default visualizerPlugin;
Expand Down
30 changes: 15 additions & 15 deletions plugins/catalog-import/report-alpha.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,21 @@ const _default: FrontendPlugin<
},
{},
{
'api:catalog-import': ExtensionDefinition<{
kind: 'api';
name: undefined;
config: {};
configInput: {};
output: ConfigurableExtensionDataRef<
AnyApiFactory,
'core.api.factory',
{}
>;
inputs: {};
params: {
factory: AnyApiFactory;
};
}>;
'page:catalog-import': ExtensionDefinition<{
kind: 'page';
name: undefined;
Expand Down Expand Up @@ -48,21 +63,6 @@ const _default: FrontendPlugin<
routeRef?: RouteRef<AnyRouteRefParams> | undefined;
};
}>;
'api:catalog-import': ExtensionDefinition<{
kind: 'api';
name: undefined;
config: {};
configInput: {};
output: ConfigurableExtensionDataRef<
AnyApiFactory,
'core.api.factory',
{}
>;
inputs: {};
params: {
factory: AnyApiFactory;
};
}>;
}
>;
export default _default;
Expand Down
Loading
Loading