Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gitlab:group:ensureExists support path objects #28439

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Make gitlab:group:ensureExists support path objects #28439

merged 3 commits into from
Jan 14, 2025

Conversation

Jenson3210
Copy link
Contributor

Hey, I just made a Pull Request!

Fixes #28392

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@Jenson3210
Updated the path field in the gitlab:group:ensureExists action to acc…
7b62987 
…ept an array of objects (with name and slug) besides the existing array of strings

Fixes backstage#28392

Signed-off-by: Jente Sondervorst <jentesondervorst@gmail.com>
@Jenson3210 Jenson3210 requested review from a team as code owners January 10, 2025 21:22
@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label Jan 10, 2025
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Jan 10, 2025 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-scaffolder-backend-module-gitlab plugins/scaffolder-backend-module-gitlab patch v0.7.1-next.1

Jenson3210 and others added 2 commits January 10, 2025 22:52
@Jenson3210
Updated api
4273db9 
Signed-off-by: Jente Sondervorst <jentesondervorst@gmail.com>
@benjdlambert
chore: updating changeset
517d822 
Signed-off-by: blam <ben@blam.sh>
benjdlambert
benjdlambert approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks! 🎉

@benjdlambert benjdlambert merged commit 55625f0 into backstage:master Jan 14, 2025
23 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.35.0 release, scheduled for Tue, 14 Jan 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjdlambert benjdlambert benjdlambert approved these changes

@Rugvip Rugvip Awaiting requested review from Rugvip Rugvip is a code owner automatically assigned from backstage/maintainers

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/reviewers

Assignees
No one assigned
Labels
area:scaffolder Everything and all things related to the scaffolder project area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Make gitlab:group:ensureExists support path objects
2 participants
@Jenson3210 @benjdlambert