Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: Add result type and filter extension points to the search plugin #28395

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Search: Add result type and filter extension points to the search plugin #28395

merged 4 commits into from
Jan 14, 2025

Conversation

marknotfound
Copy link
Contributor

@marknotfound marknotfound commented Jan 8, 2025 •
edited
Loading

Hey, I just made a Pull Request!

This PR adds two new extension points to the search plugin:

  1. A search result type extension to inject additional result types into the existing "Result Type" filter
  2. A filter extension to inject additional search filters into the UI.
image

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@marknotfound
add blueprint extension for result type filter in search plugin
d90f710 
Signed-off-by: Mark Dunphy <markd@spotify.com>
@marknotfound
add serch filter blueprint extension
0027a01 
Signed-off-by: Mark Dunphy <markd@spotify.com>
@marknotfound marknotfound requested a review from a team as a code owner January 8, 2025 02:00
@github-actions github-actions bot added search Things related to Search area:search labels Jan 8, 2025
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Jan 8, 2025 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-search-react plugins/search-react patch v1.8.5-next.0
@backstage/plugin-search plugins/search patch v1.4.22-next.1

@marknotfound
add changeset
63e1012 
Signed-off-by: Mark Dunphy <markd@spotify.com>
@marknotfound
fix api reports
97f60cc 
Signed-off-by: Mark Dunphy <markd@spotify.com>
@alexlorenzi alexlorenzi merged commit 3b80fcf into backstage:master Jan 14, 2025
24 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.36.0 release, scheduled for Tue, 18 Feb 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squid-ney squid-ney squid-ney approved these changes

@alexlorenzi alexlorenzi alexlorenzi approved these changes

Assignees
No one assigned
Labels
area:search search Things related to Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marknotfound @alexlorenzi @squid-ney