π Bug Report: lint broken after yarn backstage-cli versions:bump
Β #27500
Description
π Description
Hey team, I was performing another regular Backstage versions:bump task using the CLI and noticed a conflicting lint configuration.
The CLI version with the issue is ^0.28.2
- even the v.next.2
has this bug.
It happens because the current upstream configuration uses:
"@typescript-eslint/eslint-plugin": "^6.12.0",
"@typescript-eslint/parser": "^6.7.2",
But all the plugins are using eslint
v8.6.
The quick fix for anyone with this issue is to upgrade both dependencies to v7, e.g.:
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
Ideally they are all bumped to v8, but the v8 upgrade has more breaking changes I didn't have time to go through.
π Expected behavior
Running backstage-cli repo lint
always works if not customizations are provided over the upstream configuration.
π Actual Behavior with Screenshots
$ backstage-cli repo lint
TypeError: Failed to load plugin 'jest' declared in '.eslintrc.js': Class extends value undefined is not a constructor or null
Referenced from: /Users/dfigueiredo/code/ws/backstage/plugins/deployments-backend/.eslintrc.js
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
π Reproduction steps
- Run
yarn backstage-cli versions:bump
- Confirm CLI version is updated to
0.28.2
or greater by runningyarn why @backstage/cli
yarn backstage-cli repo lint
π Provide the context for the Bug.
No response
π₯οΈ Your Environment
yarn run v1.22.22
$ /Users/dfigueiredo/code/ws/backstage/node_modules/.bin/backstage-cli info
OS: Darwin 23.5.0 - darwin/arm64
node: v18.20.4
yarn: 1.22.22
cli: 0.28.2 (installed)
backstage: 1.32.5
Dependencies:
@backstage/app-defaults 1.5.12
@backstage/backend-app-api 0.8.0, 0.9.3, 1.0.1
@backstage/backend-common 0.23.3, 0.24.1, 0.25.0
@backstage/backend-defaults 0.4.4, 0.5.2
@backstage/backend-dev-utils 0.1.5
@backstage/backend-openapi-utils 0.1.18, 0.2.0
@backstage/backend-plugin-api 0.7.0, 0.8.1, 1.0.0, 1.0.1
@backstage/backend-tasks 0.5.27, 0.6.1
@backstage/backend-test-utils 0.4.4, 1.0.2
@backstage/catalog-client 1.7.0, 1.7.1
@backstage/catalog-model 1.7.0
@backstage/cli-common 0.1.14
@backstage/cli-node 0.2.8, 0.2.9
@backstage/cli 0.28.2
@backstage/config-loader 1.9.1
@backstage/config 1.2.0
@backstage/core-app-api 1.15.1
@backstage/core-compat-api 0.2.8, 0.3.1
@backstage/core-components 0.14.10, 0.15.1
@backstage/core-plugin-api 1.10.0, 1.9.3
@backstage/dev-utils 1.1.2
@backstage/errors 1.2.4
@backstage/eslint-plugin 0.1.10
@backstage/frontend-app-api 0.10.0
@backstage/frontend-defaults 0.1.1
@backstage/frontend-plugin-api 0.6.7, 0.7.0, 0.9.0
@backstage/frontend-test-utils 0.2.1
@backstage/integration-aws-node 0.1.12
@backstage/integration-react 1.1.30, 1.2.0
@backstage/integration 1.15.0, 1.15.1
@backstage/plugin-api-docs 0.11.11
@backstage/plugin-app-backend 0.3.76
@backstage/plugin-app-node 0.1.26
@backstage/plugin-app 0.1.1
@backstage/plugin-auth-backend-module-atlassian-provider 0.3.1
@backstage/plugin-auth-backend-module-auth0-provider 0.1.1
@backstage/plugin-auth-backend-module-aws-alb-provider 0.2.1
@backstage/plugin-auth-backend-module-azure-easyauth-provider 0.2.1
@backstage/plugin-auth-backend-module-bitbucket-provider 0.2.1
@backstage/plugin-auth-backend-module-bitbucket-server-provider 0.1.1
@backstage/plugin-auth-backend-module-cloudflare-access-provider 0.3.1
@backstage/plugin-auth-backend-module-gcp-iap-provider 0.3.1
@backstage/plugin-auth-backend-module-github-provider 0.2.1
@backstage/plugin-auth-backend-module-gitlab-provider 0.2.1
@backstage/plugin-auth-backend-module-google-provider 0.2.1
@backstage/plugin-auth-backend-module-guest-provider 0.2.1
@backstage/plugin-auth-backend-module-microsoft-provider 0.2.1
@backstage/plugin-auth-backend-module-oauth2-provider 0.3.1
@backstage/plugin-auth-backend-module-oauth2-proxy-provider 0.2.1
@backstage/plugin-auth-backend-module-oidc-provider 0.3.1
@backstage/plugin-auth-backend-module-okta-provider 0.1.1
@backstage/plugin-auth-backend-module-onelogin-provider 0.2.1
@backstage/plugin-auth-backend 0.23.1
@backstage/plugin-auth-node 0.4.17, 0.5.2, 0.5.3
@backstage/plugin-auth-react 0.1.7
@backstage/plugin-bitbucket-cloud-common 0.2.24
@backstage/plugin-catalog-backend-module-github-org 0.3.3
@backstage/plugin-catalog-backend-module-github 0.7.6
@backstage/plugin-catalog-backend-module-logs 0.1.3
@backstage/plugin-catalog-backend-module-scaffolder-entity-model 0.2.1
@backstage/plugin-catalog-backend-module-unprocessed 0.5.1
@backstage/plugin-catalog-backend 1.27.1
@backstage/plugin-catalog-common 1.1.0
@backstage/plugin-catalog-graph 0.4.11
@backstage/plugin-catalog-import 0.12.5
@backstage/plugin-catalog-node 1.13.0, 1.13.1
@backstage/plugin-catalog-react 1.12.3, 1.14.0
@backstage/plugin-catalog-unprocessed-entities-common 0.0.4
@backstage/plugin-catalog-unprocessed-entities 0.2.9
@backstage/plugin-catalog 1.24.0
@backstage/plugin-devtools-backend 0.4.1
@backstage/plugin-devtools-common 0.1.12
@backstage/plugin-devtools 0.1.19
@backstage/plugin-events-backend-module-aws-sqs 0.4.4
@backstage/plugin-events-backend-module-github 0.2.13
@backstage/plugin-events-backend 0.3.15
@backstage/plugin-events-node 0.3.10, 0.4.4
@backstage/plugin-home-react 0.1.16, 0.1.18
@backstage/plugin-home 0.8.0
@backstage/plugin-kubernetes-backend 0.18.7
@backstage/plugin-kubernetes-common 0.8.3
@backstage/plugin-kubernetes-node 0.1.20
@backstage/plugin-notifications-backend 0.4.2
@backstage/plugin-notifications-common 0.0.5
@backstage/plugin-notifications-node 0.2.8
@backstage/plugin-notifications 0.3.2
@backstage/plugin-org 0.6.31
@backstage/plugin-permission-backend-module-allow-all-policy 0.2.1
@backstage/plugin-permission-backend 0.5.50
@backstage/plugin-permission-common 0.8.1
@backstage/plugin-permission-node 0.8.3, 0.8.4
@backstage/plugin-permission-react 0.4.25, 0.4.27
@backstage/plugin-proxy-backend 0.5.7
@backstage/plugin-scaffolder-backend-module-azure 0.2.1
@backstage/plugin-scaffolder-backend-module-bitbucket-cloud 0.2.1
@backstage/plugin-scaffolder-backend-module-bitbucket-server 0.2.1
@backstage/plugin-scaffolder-backend-module-bitbucket 0.3.1
@backstage/plugin-scaffolder-backend-module-gerrit 0.2.1
@backstage/plugin-scaffolder-backend-module-gitea 0.2.1
@backstage/plugin-scaffolder-backend-module-github 0.5.1
@backstage/plugin-scaffolder-backend-module-gitlab 0.6.0
@backstage/plugin-scaffolder-backend-module-rails 0.5.1
@backstage/plugin-scaffolder-backend 1.26.2
@backstage/plugin-scaffolder-common 1.5.6
@backstage/plugin-scaffolder-node-test-utils 0.1.14
@backstage/plugin-scaffolder-node 0.5.0
@backstage/plugin-scaffolder-react 1.13.2
@backstage/plugin-scaffolder 1.26.2
@backstage/plugin-search-backend-module-catalog 0.2.4
@backstage/plugin-search-backend-module-elasticsearch 1.6.1
@backstage/plugin-search-backend-module-explore 0.2.4
@backstage/plugin-search-backend-module-pg 0.5.37
@backstage/plugin-search-backend-module-techdocs 0.3.1
@backstage/plugin-search-backend-node 1.3.4
@backstage/plugin-search-backend 1.6.1
@backstage/plugin-search-common 1.2.14
@backstage/plugin-search-react 1.7.14, 1.8.1
@backstage/plugin-search 1.4.18
@backstage/plugin-signals-backend 0.2.2
@backstage/plugin-signals-node 0.1.13
@backstage/plugin-signals-react 0.0.6
@backstage/plugin-signals 0.0.11
@backstage/plugin-techdocs-backend 1.11.1
@backstage/plugin-techdocs-common 0.1.0
@backstage/plugin-techdocs-module-addons-contrib 1.1.16
@backstage/plugin-techdocs-node 1.12.12, 1.12.11
@backstage/plugin-techdocs-react 1.2.9
@backstage/plugin-techdocs 1.11.0
@backstage/plugin-user-settings-backend 0.2.26
@backstage/plugin-user-settings-common 0.0.1
@backstage/plugin-user-settings 0.8.14
@backstage/release-manifests 0.0.11
@backstage/test-utils 1.7.0
@backstage/theme 0.5.6, 0.6.0
@backstage/types 1.1.1
@backstage/version-bridge 1.0.10, 1.0.8
Done in 0.94s.
π Have you spent some time to check if this bug has been raised before?
- I checked and didn't find similar issue
π’ Have you read the Code of Conduct?
- I have read the Code of Conduct
Are you willing to submit PR?
Yes I am willing to submit a PR!