Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support og localization based on i18n-react #149

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

golomb1
Copy link

@golomb1 golomb1 commented Nov 30, 2024

Issue #, if available:

Description of changes:
I added support for localization through i18n-react, I wrap every string in the most of the pages with localization support and added LTR/RTL support based on the language.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jessieweiyi
Copy link
Contributor

Hi @golomb1,

Thank you for your interest in Threat Composer and for submitting this pull request.

Due to current business priorities, we may not be able to review this large PR in detail before the end of the year. To facilitate the review process, we kindly request the following changes:

  1. Please split the PR into two parts:
    a) Localization support and English language support
    b) Hebrew language support

    Part b may take longer to review due to limited expertise in Hebrew within our team. Once part a is merged, you can customize Threat Composer to support Hebrew in a self-deployed instance.

  2. We use projen to manage projects, package.json files, and dependencies. To add a new dependency:

  3. We use yarn as our package manager. Please:

    • Revert the addition of the package-lock.json file
    • Retain the yarn.lock file
    • Run yarn install to install node dependencies
  4. Please remove any extra console.log statements that were added to the project.

These changes will help us review and integrate your contributions more efficiently. We appreciate your understanding and cooperation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants