Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arikawa #4506

Merged
merged 2 commits into from
Jan 7, 2025
Merged

add arikawa #4506

merged 2 commits into from
Jan 7, 2025

Conversation

tildezero
Copy link
Contributor

@tildezero tildezero commented Oct 7, 2022

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below that apply before you submit PR.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for detials.

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.
  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • I have read the Contribution Guidelines, Maintainers Note and Quality Standards.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • The authors of the project do not commit directly to the repo, but rather use pull requests that run the continuous-integration process.

Thanks for your PR, you're awesome! 👍

@avelino
Copy link
Owner

avelino commented Oct 7, 2022

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Automation body links content check:

  • godoc.org or pkg.go.dev: True
  • goreportcard.com: True
  • coverage: True

your project is about to be approved, it's under revision, it may take a few days

@yassinebenaid
Copy link
Collaborator

Test coverage is missing, Neither this PR nor the project's Ci tells anything about the test coverage.

@phanirithvij phanirithvij removed the needs-conflict-resolution Cannot merge due to conflicts label Aug 15, 2024
@yassinebenaid
Copy link
Collaborator

yassinebenaid commented Aug 15, 2024

Edit:
The workflow https://github.com/diamondburned/arikawa/actions/runs/10295010789/job/28494062726

reports the coverage as :

...
total:		(statements)	28.1%

which lower than the threshold (80%)

@phanirithvij phanirithvij merged commit 3c18f1d into avelino:main Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants