Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow context error message in Changing validation #1677

Merged
merged 4 commits into from
Dec 27, 2024
+154 −187
Merged

Allow context error message in Changing validation #1677

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0cc6729
refactor: reduce Changing test noise
binarypaladin Dec 25, 2024
4460694
improvement: test atomic and non-atomic validation paths
binarypaladin Dec 25, 2024
96ffc4b
fix: use context message instead of default if provided
binarypaladin Dec 25, 2024
eb074f1
refactor: DRY up Changing validation
binarypaladin Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improvement: test atomic and non-atomic validation paths
  • Loading branch information
@binarypaladin
binarypaladin committed Dec 25, 2024
commit 4460694db6b8c3da833905452ed04477a42111b8
91 changes: 53 additions & 38 deletions test/resource/validation/changing_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,12 @@ defmodule Ash.Test.Resource.Validation.ChangingTest do
defaults [:read, create: :*, update: :*]

update :ensure_order_changing do
require_atomic? false
validate changing(:order)
end

update :ensure_author_changing do
require_atomic? false
validate changing(:author)
end

Expand All @@ -70,67 +72,80 @@ defmodule Ash.Test.Resource.Validation.ChangingTest do
end
end

describe "Ash.Resource.Validation.Changing atomic validation" do
test "fails if attribute is not changing" do
post = Ash.create!(Post, %{title: "foo", order: 1})
def assert_invalid_updates(
%resource_module{} = resource,
action,
input,
message \\ "must be changing"
) do
assert_raise Ash.Error.Invalid, ~r/#{message}/, fn ->
resource
|> Ash.Changeset.for_update(action, input)
|> Ash.update!(atomic_upgrade?: false)
end

assert_raise Ash.Error.Invalid, ~r/must be changing/, fn ->
Post
|> Ash.Query.filter(id == ^post.id)
|> Ash.bulk_update!(:ensure_order_changing, %{})
end
assert_raise Ash.Error.Invalid, ~r/#{message}/, fn ->
resource_module
|> Ash.Query.filter(id == ^resource.id)
|> Ash.bulk_update!(action, input)
end
end

test "fails if attribute is being set to the same value" do
post = Ash.create!(Post, %{title: "foo", order: 1})
def assert_valid_updates(%resource_module{} = resource, action, input) do
assert %Ash.BulkResult{status: :success} =
resource_module
|> Ash.Query.filter(id == ^resource.id)
|> Ash.bulk_update!(action, input)

# Ensures the non-atomic version works even if the data layer has already
# been updated.
assert resource
|> Ash.Changeset.for_update(action, input)
|> Ash.update!(atomic_upgrade?: false)
end

assert_raise Ash.Error.Invalid, ~r/must be changing/, fn ->
Post
|> Ash.Query.filter(id == ^post.id)
|> Ash.bulk_update!(:ensure_order_changing, %{order: 1})
end
describe "Ash.Resource.Validation.Changing" do
test "fails if attribute is not changing" do
Post
|> Ash.create!(%{title: "foo", order: 1})
|> assert_invalid_updates(:ensure_order_changing, %{})
end

test "succeeds if attribute changing to another value" do
post = Ash.create!(Post, %{title: "foo", order: 1})
test "fails if attribute is being set to the same value" do
Post
|> Ash.create!(%{title: "foo", order: 1})
|> assert_invalid_updates(:ensure_order_changing, %{order: 1})
end

assert %Ash.BulkResult{status: :success} =
Post
|> Ash.Query.filter(id == ^post.id)
|> Ash.bulk_update!(:ensure_order_changing, %{order: 2})
test "succeeds if attribute changing to another value" do
Post
|> Ash.create!(%{title: "foo", order: 1})
|> assert_valid_updates(:ensure_order_changing, %{order: 2})
end

test "fails if relationship is not changing" do
author = Ash.create!(Author, %{name: "fred"})
post = Ash.create!(Post, %{title: "foo", author_id: author.id})

assert_raise Ash.Error.Invalid, ~r/must be changing/, fn ->
Post
|> Ash.Query.filter(id == ^post.id)
|> Ash.bulk_update!(:ensure_author_changing, %{})
end
Post
|> Ash.create!(%{title: "foo", author_id: author.id})
|> assert_invalid_updates(:ensure_author_changing, %{})
end

test "fails if relationship is being set to the same value" do
author = Ash.create!(Author, %{name: "fred"})
post = Ash.create!(Post, %{title: "foo", author_id: author.id})

assert_raise Ash.Error.Invalid, ~r/must be changing/, fn ->
Post
|> Ash.Query.filter(id == ^post.id)
|> Ash.bulk_update!(:ensure_author_changing, %{author_id: author.id})
end
Post
|> Ash.create!(%{title: "foo", author_id: author.id})
|> assert_invalid_updates(:ensure_author_changing, %{author_id: author.id})
end

test "succeeds if relationship is being set to another value" do
author1 = Ash.create!(Author, %{name: "fred"})
author2 = Ash.create!(Author, %{name: "george"})
post = Ash.create!(Post, %{title: "foo", author_id: author1.id})

assert %Ash.BulkResult{status: :success} =
Post
|> Ash.Query.filter(id == ^post.id)
|> Ash.bulk_update!(:ensure_author_changing, %{author_id: author2.id})
Post
|> Ash.create!(%{title: "foo", author_id: author1.id})
|> assert_valid_updates(:ensure_author_changing, %{author_id: author2.id})
end

test "returns :not_atomic on has_many relationships" do
Expand Down