Allow context error message in Changing validation #1677
Merged
+154
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is just noisy with a lot of verbosity that actually makes working with it and reading it harder than it needs to be.
Having just fixed issues with the error message, replacing
`{:error, exception(opts, context)}` fives times implied some
consolidation was in order.
zachdaniel
approved these changes
Dec 27, 2024
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-atomic validation failures did not respect the
:messageprovided in the context if it was present.As is obvious, this little change took me down a bit of clean-up/refactor rabbit hole. It's a compulsion.
Contributor checklist