Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Missing Parser grammar] First monday of august #198

Open
Ari24-cb24 opened this issue Oct 29, 2022 · 2 comments · Fixed by #205
Open

[Missing Parser grammar] First monday of august #198

Ari24-cb24 opened this issue Oct 29, 2022 · 2 comments · Fixed by #205
Assignees
@Ari24-cb24
Labels
evaluator Used for any kinds of issues with the evaluator evaluator-grammar Used for any kinds of issues with evaluator-grammar parser Used for any kinds of issues with the parser parser-grammar Used for any kinds of issues with parser-grammar

Comments

@Ari24-cb24
Copy link
Member

Ari24-cb24 commented Oct 29, 2022 •
edited
Loading

Given input

  • First monday of august

Some extra notes

Needs an extra parsing method.
<N°><a> of <b>

<N°> NumberCountConstant
<a>: DatetimeConstant, WeekdayConstant and MonthConstant
<b>: I think a mix of Absolute Preposition and Constants(extension)
@Ari24-cb24 Ari24-cb24 added parser Used for any kinds of issues with the parser parser-grammar Used for any kinds of issues with parser-grammar labels Oct 29, 2022
@Ari24-cb24 Ari24-cb24 self-assigned this Oct 29, 2022
@Ari24-cb24
Copy link
Member Author

I would call it AbsoluteTargetedPreposition

@Ari24-cb24
Copy link
Member Author

Tho the more I think about it, it has to be implemented into the absolute prepositions as three days after xyz are also possible. If this would be another parsing method, recursion would occur

Ari24-cb24 added a commit that referenced this issue Mar 28, 2023
@Ari24-cb24
Fixed #198
e69c87b
@Ari24-cb24 Ari24-cb24 mentioned this issue Mar 28, 2023
Merged
5 tasks
@Ari24-cb24 Ari24-cb24 added evaluator Used for any kinds of issues with the evaluator evaluator-grammar Used for any kinds of issues with evaluator-grammar labels Mar 28, 2023
@Ari24-cb24 Ari24-cb24 linked a pull request Mar 28, 2023 that will close this issue
Added parsing and evaluating of first monday of august #205
Merged
5 tasks
Ari24-cb24 added a commit that referenced this issue Apr 3, 2023
@Ari24-cb24
Merge pull request #205 from aridevelopment-de/#198/dev
6e49149 
Added parsing and evaluating of `first monday of august`

Co-authored-by: @Inf-inity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ari24-cb24 Ari24-cb24

Labels
evaluator Used for any kinds of issues with the evaluator evaluator-grammar Used for any kinds of issues with evaluator-grammar parser Used for any kinds of issues with the parser parser-grammar Used for any kinds of issues with parser-grammar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added parsing and evaluating of first monday of august aridevelopment-de/datetimeparser
1 participant
@Ari24-cb24