Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packaging issue: deployment of tests #537

Open
noraj opened this issue May 7, 2023 · 1 comment
Open

packaging issue: deployment of tests #537

noraj opened this issue May 7, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@noraj
Copy link

noraj commented May 7, 2023

What happened

The issue is that the setup.py is deploying the tests folder under the root python path and not under this package one.

So it's end up under /usr/lib/python3.11/site-packages/tests rather than /usr/lib/python3.11/site-packages/kube-hunter/tests and so conflicts with other packages having the same issue.

Anyway usually test are not shipped in a release package so the easiest would just to remove them. Else they should be deployed in the children directory.

It's explained in ArchLinux packaging guidelines for Python: https://wiki.archlinux.org/title/Python_package_guidelines#Test_directory_in_site-package

Expected behavior

No file deployed on the root python path.
@noraj noraj added the bug Something isn't working label May 7, 2023
@noraj
Copy link
Author

noraj commented May 7, 2023

Usually this fix in setup.py is enough:

-packages=find_packages(),
+packages=find_packages(exclude=["tests*"]),

But this method is not used here, so I won't PR as I don't know what's required to exclude the tests folder in this case.

@noraj noraj mentioned this issue May 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noraj