Making ivBytes accessible for _CBC.IV #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, this is a change we're generally happy to make. Can I make a few requests? Firstly, let's prefer to offer an API that exposes an Secondly, can you add a unit test that drives that API? It'll help us avoid regressing it. |
|
That is interesting about the [UInt8] because that is how I use it in my code, and had to repeat a lot of ivBytes.0, 1, 2,... So I'm happy to expose and API and unit tests |
|
Closing in favor of #261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation:
Right now, we're using CommonCrypto and would like to switch to Crypto instead. However, the requirement we need is that we send the data for IV to the server for them to verify the signature we are sending them. Similarly, they send us their IV and we verify the signature of other data. (Which is supported currently)
Modifications:
By making
ivBytespublic, we can access the randomly generated salt for our cipher.Result:
I can replace CommonCrypto code in my repo with Crypto instead :)