Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize Objective-C #4639

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Modernize Objective-C #4639

wants to merge 3 commits into from

Conversation

RSilicon
Copy link
Contributor

@RSilicon RSilicon commented Oct 2, 2022

We should use shorthand to simplify the Objective-C in this codebase.

@RSilicon
Copy link
Contributor Author

RSilicon commented Oct 2, 2022

@Kyle-Ye Could you please test?

@Kyle-Ye
Copy link
Collaborator

Kyle-Ye commented Oct 2, 2022

@swift-ci please test

@RSilicon
Copy link
Contributor Author

This good?

@RSilicon
Copy link
Contributor Author

@drexin thoughts?

@parkera
Copy link
Member

parkera commented Dec 5, 2022

Unfortunately this ObjC is basically dead code in this repo, so updating it here won't really do anything.

RSilicon and others added 3 commits January 28, 2023 20:32
@RSilicon
Modernize Objective-C
102f252
@RSilicon @ffried
Update Darwin/Foundation-swiftoverlay/DataThunks.m
772dea3 
Co-authored-by: Florian Friedrich <ffried@me.com>
@RSilicon @ffried
Update Darwin/Foundation-swiftoverlay/DataThunks.m
bb4468a 
Co-authored-by: Florian Friedrich <ffried@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffried ffried ffried left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RSilicon @Kyle-Ye @parkera @ffried