Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially wrong number of argument in cumsum op #2303

Open
msluszniak opened this issue Aug 9, 2024 · 1 comment
Open

Potentially wrong number of argument in cumsum op #2303

msluszniak opened this issue Aug 9, 2024 · 1 comment
Labels
bug Unexpected behaviour that should be corrected (type)

Comments

@msluszniak
Copy link

I discovered that the expected number of arguments to cumsum op in coremltools might be wrong while exporting PyTorch module to *.pte file (executorch). See

coremltools/coremltools/converters/mil/frontend/torch/ops.py

Line 931 in 8b7048e

inputs = _get_inputs(context, node, expected=3)
Number of arguments is set to 3 while only two are used. Indeed, in my export, I got an error that cumsum op expects 3 arguments while only 2 were provided. Changing this value to 2 fixed suppressed the error.

To Reproduce

I'm not able to reproduce the error with small code sample.

System environment (please complete the following information):

  • coremltools version: 8.0b1
  • OS (e.g. MacOS version or Linux type): MacOS Version 14.5
  • Any other relevant version information (e.g. PyTorch or TensorFlow version): PyTorch 2.5.0.dev20240716

Additional context

Discovered this while exporting Pytorch model to executorch with CoreML backend.
@msluszniak msluszniak added the bug Unexpected behaviour that should be corrected (type) label Aug 9, 2024
@jakesabathia2
Copy link
Collaborator

Right now the torch version coremltools officially supports is 2.3.0 (https://github.com/apple/coremltools/blob/main/coremltools/_deps/__init__.py#L156),
while your enviroment got 2.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected behaviour that should be corrected (type)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakesabathia2 @msluszniak