Hi @markblee,

Both ruomingp and jiarui-lu2 have approved the changes to the PR. Could you please take a final look when you get a chance? Thanks again for your time!

Best,
Vishesh

Hi @vishesh9131, I think PR check was on hold due to a required approval in CI. I've approved it and CI should be starting now

@jiarui-lu2
@ruomingp
@markblee

Do I Need to modify .circleci/config.yml to include the installation of the latest aqt package, since there is an issue occurring in a CircleCI environment...
I mean modification in .circleci/config.yml like this :

 build:
    docker:
      - image: circleci/python:3.9
    steps:
      - checkout
      - run:
          name: Install dependencies
          command: |
            python -m pip install --upgrade pip
            pip install aqt
      - run:
          name: Run pytype
          command: pytype -j auto

@jiarui-lu2 @ruomingp @markblee

Do I Need to modify .circleci/config.yml to include the installation of the latest aqt package, since there is an issue occurring in a CircleCI environment... I mean modification in .circleci/config.yml like this :

 build:
    docker:
      - image: circleci/python:3.9
    steps:
      - checkout
      - run:
          name: Install dependencies
          command: |
            python -m pip install --upgrade pip
            pip install aqt
      - run:
          name: Run pytype
          command: pytype -j auto

I don't think upgrading aqt is recommended. Minimum python version supported by axlearn is python3.9, however last time I checked for aqt>=0.5.0, minimum supported python version is python3.10 due to the use of newly introduced typing aliases. If this PR relies on aqt>=0.5.0, I think we should close it until either aqt fixes this issue, or axlearn is ready to upgrade its minimum python version requirements.

Hi @jiarui-lu2 ,

I understand your concerns regarding the aqt package and its compatibility with Python 3.9. I wanted to inform you that the latest version of aqt (>=0.5.0) supports Python 3.10.
Would it be possible to consider upgrading the CircleCI configuration to use Python 3.10? This would allow us to use the latest aqt package and resolve the current issue.
Please let me know your thoughts on this.

Best regards,
@vishesh9131

Hi @jiarui-lu2 ,

I understand your concerns regarding the aqt package and its compatibility with Python 3.9. I wanted to inform you that the latest version of aqt (>=0.5.0) supports Python 3.10. Would it be possible to consider upgrading the CircleCI configuration to use Python 3.10? This would allow us to use the latest aqt package and resolve the current issue. Please let me know your thoughts on this.

Best regards, @vishesh9131

The main concern I have is not of Circle CI. axlearn repo formally supports python3.9 as stated here. Depending on a package aqt>-0.5.0 that has a minimum requirement of python3.10 breaks that support. Which is why I said

I think we should close it until either aqt fixes this issue, or axlearn is ready to upgrade its minimum python version requirements.

Hi @jiarui-lu2 ,

I understand your concern about maintaining Python 3.9 support for the axlearn repo. Given that aqt>=0.5.0 requires Python 3.10, I agree that we should close this PR until either aqt addresses this issue or axlearn is ready to upgrade its minimum Python version requirements.
Thanks for the clarification.

Best,
@vishesh9131

According to the discussions, closing PR due to python minimum version support. We should revisit if axlearn increases its minimum python version support to > =3.10

According to the discussions, closing PR due to python minimum version support. We should revisit if axlearn increases its minimum python version support to > =3.10

Hi @jiarui-lu2,

Since Axlearn now supports Python 3.10, could you reopen this closed PR? According to the previous discussions, the closure was due to the minimum Python version support issue. Now that the support has been updated, it seems like a good time to revisit.

Best regards,
Vishesh