[SUREFIRE-2278] Don't say please. (#792)

apache · Oct 16, 2024 · f144b13 · f144b13
1 parent 68b0528
commit f144b13
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 16 deletions.
diff --git a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
@@ -270,11 +270,11 @@ private static String createErrorMessage(
                         .append(reportParameters.getFailOnFlakeCount())
                         .append(".");
             }
-            msg.append("\n\nPlease refer to ")
+            msg.append("\n\nSee ")
                     .append(reportParameters.getReportsDirectory())
                     .append(" for the individual test results.")
                     .append('\n')
-                    .append("Please refer to dump files (if any exist) ")
+                    .append("See dump files (if any exist) ")
                     .append(DUMP_FILES_PRINT[0])
                     .append(", ")
                     .append(DUMP_FILES_PRINT[1])

diff --git a/maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/SurefireHelperTest.java b/maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/SurefireHelperTest.java
@@ -163,8 +163,8 @@ public void shouldHandleFailIfNoTests() throws Exception {
     public void shouldHandleTestFailure() throws Exception {
         RunResult summary = new RunResult(1, 0, 1, 0);
         e.expect(MojoFailureException.class);
-        e.expectMessage("There are test failures.\n\nPlease refer to null "
-                + "for the individual test results.\nPlease refer to dump files (if any exist) "
+        e.expectMessage("There are test failures.\n\nSee null "
+                + "for the individual test results.\nSee dump files (if any exist) "
                 + "[date].dump, [date]-jvmRun[N].dump and [date].dumpstream.");
         reportExecution(new Mojo(), summary, null, null);
     }
@@ -175,8 +175,8 @@ public void failsIfThereAreTooManyFlakes() throws Exception {
         Mojo reportParameters = new Mojo();
         reportParameters.setFailOnFlakeCount(1);
         e.expect(MojoFailureException.class);
-        e.expectMessage("There is 1 flake and failOnFlakeCount is set to 1.\n\nPlease refer to null "
-                + "for the individual test results.\nPlease refer to dump files (if any exist) "
+        e.expectMessage("There is 1 flake and failOnFlakeCount is set to 1.\n\nSee null "
+                + "for the individual test results.\nSee dump files (if any exist) "
                 + "[date].dump, [date]-jvmRun[N].dump and [date].dumpstream.");
         reportExecution(reportParameters, summary, null, null);
     }
@@ -188,8 +188,8 @@ public void reportsFailuresAndFlakes() throws Exception {
         reportParameters.setFailOnFlakeCount(1);
         e.expect(MojoFailureException.class);
         e.expectMessage("There are test failures.\nThere are 2 flakes and failOnFlakeCount is set to 1."
-                + "\n\nPlease refer to null "
-                + "for the individual test results.\nPlease refer to dump files (if any exist) "
+                + "\n\nSee null "
+                + "for the individual test results.\nSee dump files (if any exist) "
                 + "[date].dump, [date]-jvmRun[N].dump and [date].dumpstream.");
         reportExecution(reportParameters, summary, null, null);
     }

diff --git a/maven-surefire-plugin/src/test/java/org/apache/maven/plugin/surefire/SurefireMojoTest.java b/maven-surefire-plugin/src/test/java/org/apache/maven/plugin/surefire/SurefireMojoTest.java
@@ -67,14 +67,14 @@ public void testTestFailure() throws Exception {
             mojo.handleSummary(runResult, null);
         } catch (MojoFailureException e) {
             assertThat(e.getLocalizedMessage())
-                    .isEqualTo("There are test failures.\n\nPlease refer to null "
-                            + "for the individual test results.\nPlease refer to dump files (if any exist) "
+                    .isEqualTo("There are test failures.\n\nSee null "
+                            + "for the individual test results.\nSee dump files (if any exist) "
                             + "[date].dump, [date]-jvmRun[N].dump and [date].dumpstream.");
             return;
         }
         fail("Expected MojoFailureException with message "
-                + "'There are test failures.\n\nPlease refer to null "
-                + "for the individual test results.\nPlease refer to dump files (if any exist) "
+                + "'There are test failures.\n\nSee null "
+                + "for the individual test results.\nSee dump files (if any exist) "
                 + "[date].dump, [date]-jvmRun[N].dump and [date].dumpstream.'");
     }
 

diff --git a/surefire-api/src/main/java/org/apache/maven/surefire/api/util/RunOrder.java b/surefire-api/src/main/java/org/apache/maven/surefire/api/util/RunOrder.java
@@ -81,7 +81,7 @@ private static String createMessageForMissingRunOrder(String name) {
         RunOrder[] runOrders = values();
         StringBuilder message = new StringBuilder("There's no RunOrder with the name ");
         message.append(name);
-        message.append(". Please use one of the following RunOrders: ");
+        message.append(". Use one of the following RunOrders: ");
         for (int i = 0; i < runOrders.length; i++) {
             if (i != 0) {
                 message.append(", ");

diff --git a/...urefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/AsynchronousRunner.java b/...urefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/AsynchronousRunner.java
@@ -30,7 +30,7 @@
 
 /**
  * Since SUREFIRE 2.18 this class is deprecated.
- * Please use {@link org.apache.maven.surefire.junitcore.pc.ParallelComputerBuilder} instead.
+ * Use {@link org.apache.maven.surefire.junitcore.pc.ParallelComputerBuilder} instead.
  *
  * @author <a href="mailto:kristian@zenior.no">Kristian Rosenvold</a>
  */

diff --git a/...nit47/src/main/java/org/apache/maven/surefire/junitcore/ConfigurableParallelComputer.java b/...nit47/src/main/java/org/apache/maven/surefire/junitcore/ConfigurableParallelComputer.java
@@ -37,7 +37,7 @@
 
 /**
  * Since SUREFIRE 2.18 this class is deprecated.
- * Please use {@link org.apache.maven.surefire.junitcore.pc.ParallelComputerBuilder} instead.
+ * Use {@link org.apache.maven.surefire.junitcore.pc.ParallelComputerBuilder} instead.
  *
  * @author Kristian Rosenvold
  */

diff --git a/...surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/SynchronousRunner.java b/...surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/SynchronousRunner.java
@@ -22,7 +22,7 @@
 
 /**
  * Since SUREFIRE 2.18 this class is deprecated.
- * Please use {@link org.apache.maven.surefire.junitcore.pc.ParallelComputerBuilder} instead.
+ * Use {@link org.apache.maven.surefire.junitcore.pc.ParallelComputerBuilder} instead.
  *
  * @author <a href="mailto:kristian@zenior.no">Kristian Rosenvold</a>
  */