Update to savon 2.3.0, remove namespace workaround

anshulacro · Jul 30, 2013 · f05fb3d · f05fb3d
1 parent 76c8c9b
commit f05fb3d
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 10 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -2,6 +2,8 @@
 
 [full changelog](http://github.com/yolk/valvat/compare/v0.5.0...master)
 
+* Works now with current version of savon gem (2.3.0) (by [liggitt](https://github.com/liggitt))
+
 ### 0.5.0 / 2013-07-18
 
 [full changelog](http://github.com/yolk/valvat/compare/v0.4.7...v0.5.0)

diff --git a/gemfiles/activemodel-3-2 b/gemfiles/activemodel-3-2
@@ -1,6 +1,6 @@
 source "http://rubygems.org"
 
-gem "savon",       "2.2.0"
+gem "savon",       "2.3.0"
 gem "activemodel", "3.2.13"
 
 gem 'rspec', '>= 2.4.0'

diff --git a/gemfiles/activemodel-4 b/gemfiles/activemodel-4
@@ -1,6 +1,6 @@
 source "http://rubygems.org"
 
-gem "savon",       "2.2.0"
+gem "savon",       "2.3.0"
 gem "activemodel", "4.0"
 
 gem 'rspec', '>= 2.4.0'

diff --git a/gemfiles/standalone b/gemfiles/standalone
@@ -1,6 +1,6 @@
 source "http://rubygems.org"
 
-gem "savon",       "2.2.0"
+gem "savon",       "2.3.0"
 
 gem 'rspec', '>= 2.4.0'
 gem 'fakeweb', '>= 1.3.0'

diff --git a/lib/valvat/lookup.rb b/lib/valvat/lookup.rb
@@ -31,14 +31,9 @@ def self.client
         # Require Savon only if really needed!
         require 'savon' unless defined?(Savon)
 
-        # Quiet down HTTPI
-        HTTPI.log = false
-
         Savon::Client.new(
           wsdl: 'http://ec.europa.eu/taxation_customs/vies/checkVatService.wsdl',
-          namespace: 'urn:ec.europa.eu:taxud:vies:services:checkVat:types',
-          namespaces: {'xmlns:impl'=>'urn:ec.europa.eu:taxud:vies:services:checkVat:types'},
-          # Quiet down Savon
+          # Quiet down Savon and HTTPI
           log: false
         )
       end

diff --git a/valvat.gemspec b/valvat.gemspec
@@ -28,7 +28,7 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  s.add_dependency             'savon',       '>=2.2.0'
+  s.add_dependency             'savon',       '>=2.3.0'
 
   s.add_development_dependency 'rspec',       '>= 2.4.0'
   s.add_development_dependency 'guard-rspec', '>=0.1.9'