Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing assertions on unit tests #332

Open
wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from

Conversation

sayantandey
Copy link

@sayantandey sayantandey commented May 13, 2023

Description

Dummy PR to show that JUnits in PR pipeline tests will pass even after changing the logic.
Missing unit test assertions for RequestResponseUtils

Module : ask-sdk-local-debug

This pull request shows even with modified code logic , the unit tests pass.

I have modified some logics in this utils to show that assertions are not sufficient.

This issue might be found in other modules, need to be checked.

Motivation and Context

  • This is a pull request to show even with code logics being changed, the unit tests passes
  • One code snippet missed by unit test

Testing

  • Changed few code blocks and ran the Junits.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

    Additional assertions required

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sayantandey
Copy link
Author

sayantandey commented May 14, 2023

This is a dummy PR to show that tests in the pipeline will pass even after code logic is removed and changed.
Don't merge. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant