Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async rendering API and "pure" image fetching #472

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

Async rendering API and "pure" image fetching #472

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
a69b850
Transpile to ES2017 to avoid regenerator-runtime for now
lordofthelake Jan 20, 2020
042fdae
Use weakRequire instead of ad-hoc evals
lordofthelake Jan 20, 2020
22b7f60
Make everything async
lordofthelake Jan 20, 2020
2968a64
Add getImageDataFromURL() implementation using fetch
lordofthelake Jan 20, 2020
1ad2d17
Split the bridges in their own objects
lordofthelake Jan 21, 2020
dfd88c9
Change the interface of getSketchVersion()
lordofthelake Jan 21, 2020
08d1a2e
Use strong imports in NodeMacOSBridge
lordofthelake Jan 21, 2020
f9c83a9
Add PlatformBridge injection everywhere
lordofthelake Jan 21, 2020
67fc4ce
Group together files by method instead than by implementation
lordofthelake Jan 21, 2020
6d6c801
Rename the *SJSON functions
lordofthelake Jan 21, 2020
5bae926
Don't use the console in prodution
lordofthelake Jan 21, 2020
d849c9b
Reorganize exports
lordofthelake Jan 22, 2020
b8bc142
Split entrypoints by platform
lordofthelake Jan 22, 2020
2d063e6
Change the bridge injection for TextStyles
lordofthelake Jan 22, 2020
0dbd5b0
Use a dynamic import instead of weakRequire
lordofthelake Jan 22, 2020
12dd68c
Fix compilation errors
lordofthelake Jan 22, 2020
435bce2
Move back StyleSheet -> stylesheet
lordofthelake Jan 22, 2020
65e011d
Fix the test suite
lordofthelake Jan 22, 2020
9c82687
Add multiple entrypoints in package.json
lordofthelake Jan 22, 2020
b267fcd
Add the node-fetch dependency
lordofthelake Jan 22, 2020
8e6b485
Revert targeting es5
lordofthelake Jan 22, 2020
7bacf27
Update @skpm/builder everywhere
lordofthelake Jan 22, 2020
48766e4
Add implementation to read from file: protocol
lordofthelake Jan 23, 2020
8d6d1ff
Add TODO about moving the bridge out
lordofthelake Jan 23, 2020
414c845
Merge branch 'master' of github.com:compositive/react-sketchapp into …
lordofthelake Jan 23, 2020
a0a9012
Fix types to work with strict
lordofthelake Jan 23, 2020
87b175a
Use static platform switching
lordofthelake Jan 23, 2020
13ee09d
Don't account for skpm-fetch peculiarities
lordofthelake Jan 23, 2020
f88bd56
Add npm build to Travis to check whether the types work
lordofthelake Jan 23, 2020
f143562
Add sideEffects flag to allow tree shaking
lordofthelake Jan 23, 2020
87ff628
Revert changes to getSketchVersion()
lordofthelake Jan 25, 2020
5adf6b5
Revert changes to logging
lordofthelake Jan 25, 2020
a6ddb65
Revert adding extra scripts to examples/profile-cards
lordofthelake Jan 25, 2020
7c41cf6
Revert renaming the *SJON functions
lordofthelake Jan 25, 2020
d5a3f26
Start documenting changes
lordofthelake Jul 11, 2020
215adec
Update TypeScript version
lordofthelake Jul 11, 2020
7c6c02f
Merge branch 'master' of github.com:airbnb/react-sketchapp into pure-…
lordofthelake Jan 6, 2021
cadae33
Fix the TypeScript errors
lordofthelake Jan 6, 2021
bc20d9d
Update API docs
lordofthelake Jan 6, 2021
c0b681d
Clean up left-overs of refactors already implemented
lordofthelake Jan 6, 2021
8708fc2
Correct the link to the `PlatformBridge` type
lordofthelake Jan 6, 2021
55b2c3d
Disable node_modules cache
lordofthelake Jan 6, 2021
9cbae7b
Forcibly clean the cached node_modules
lordofthelake Jan 6, 2021
8b02a46
Remove footnote in `API.md`
lordofthelake Jan 6, 2021
79fec51
Merge branch 'master' into pure-make-image-from-url-implementation
lordofthelake Mar 30, 2021
21e52ee
Update Travis config and npm
lordofthelake Apr 8, 2021
451cadb
Merge branch 'pure-make-image-from-url-implementation' of github.com:…
lordofthelake Apr 8, 2021
7c6da8e
Change the compile target to `es2017` in tsconfig.json
lordofthelake Apr 8, 2021
abffbba
Don't use the npm cache
lordofthelake Apr 8, 2021
2bc1bf6
Add libraries for retrocompatibility
lordofthelake Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add libraries for retrocompatibility
  • Loading branch information
@lordofthelake
lordofthelake committed Apr 8, 2021
commit 2bc1bf64bc211c67391b264be421c9265200984a
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@
"normalize-css-color": "^1.0.1",
"pegjs": "^0.10.0",
"prop-types": "^15.7.2",
"regenerator-runtime": "^0.13.7",
"seedrandom": "^3.0.5",
"whatwg-url": "^7.1.0",
"yoga-layout-prebuilt": "^1.9.5"
},
"peerDependencies": {
Expand Down Expand Up @@ -91,6 +93,7 @@
"@types/react": "^16.9.34",
"@types/react-test-renderer": "^16.9.2",
"@types/seedrandom": "^2.4.28",
"@types/whatwg-url": "^8.2.0",
"gitbook-cli": "^2.3.0",
"gitbook-plugin-anchorjs": "^2.1.0",
"gitbook-plugin-codeblock-disable-glossary": "0.0.1",
Expand Down
1 change: 1 addition & 0 deletions src/utils/getImageDataFromURL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import sha1 from 'js-sha1';
import { PlatformBridge } from '../types';
import { URL } from 'whatwg-url';

const ERROR_IMAGE =
'iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mM8w8DwHwAEOQHNmnaaOAAAAABJRU5ErkJggg==';
Expand Down
1 change: 1 addition & 0 deletions tsconfig.module.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"extends": "./tsconfig",
"compilerOptions": {
"target": "es5",
"outDir": "lib/module",
"module": "esnext"
},
Expand Down