-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Support unequal length for rocket transformers #2449
Comments
@maorgranot1 for tracking |
See The problem comes when the shortest series in transform is shorter than the shortest seem in fit. In this case the convolution overruns the the transform data causing and out of bounds exception. so if you remember we had a long discussion about this and did not agree on how best to do it. This issue effects RDST and to a lesser extent the shapelet transform too. Solutions considered and rejected in discussion were
basically its an algorithmic component on how to do this and the there is no published way of doing this. The legacy multivariate/minirocket approach involved concatenation over channels and zero padding, was more arbitrary than the above solutions. |
discussed this with @angus924 today, we agreed the best way to handle it was to pad any series shorter than the shortest seem in fit. Any thoughts @baraline @MatthewMiddlehurst? |
Seems like a resonable strategy, the other alternative are not very satisfying anyway. Throwing a warning when this happens to notify the user of it happening in the background and this will do it IMO |
@TonyBagnall just to confirm, we create kernels based on the shortest series in fit then if we pad to shortests during transform? |
Describe the feature or idea you want to propose
We previously had this feature, but it has gone away during the refactoring of the many versions of the rocket transformers.
Describe your proposed solution
Implement the functionality back with using numba Typed List as X type. Would need to benchmark if it is worth doing another version for unequal length, or if the adaptation doesn't harm performance significatively.
Describe alternatives you've considered, if relevant
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: