Merge pull request #325 from actiontech/1956mvp3-1

feat: support mark instance enable backup
actiontech · Nov 22, 2024 · 1feab39 · 1feab39
2 parents a943dbc + 2d76460
commit 1feab39
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/internal/dms/biz/db_service.go b/internal/dms/biz/db_service.go
@@ -73,6 +73,7 @@ type DBService struct {
 	AuditPlanTypes []*dmsCommonV1.AuditPlanTypes `json:"audit_plan_types"`
 	// instance audit plan id
 	InstanceAuditPlanID uint `json:"instance_audit_plan_id"`
+	EnableBackup        bool `json:"enable_backup"`
 }
 
 type DBTypeCount struct {
@@ -119,6 +120,7 @@ func newDBService(args *BizDBServiceArgs) (*DBService, error) {
 		MaintenancePeriod: args.MaintenancePeriod,
 		SQLEConfig:        &SQLEConfig{},
 		IsMaskingSwitch:   args.IsMaskingSwitch,
+		EnableBackup:      args.EnableBackup,
 	}
 
 	if args.RuleTemplateName != "" {
@@ -189,6 +191,7 @@ type BizDBServiceArgs struct {
 	RuleTemplateID   string
 	SQLQueryConfig   *SQLQueryConfig
 	IsMaskingSwitch  bool
+	EnableBackup     bool
 }
 
 type SQLQueryConfig struct {
@@ -642,6 +645,7 @@ func (d *DBServiceUsecase) UpdateDBService(ctx context.Context, dbServiceUid str
 		ds.AdditionalParams = updateDBService.AdditionalParams
 		ds.MaintenancePeriod = updateDBService.MaintenancePeriod
 		ds.IsMaskingSwitch = updateDBService.IsMaskingSwitch
+		ds.EnableBackup = updateDBService.EnableBackup
 		ds.SQLEConfig = &SQLEConfig{}
 		// 支持新增和更新sqleConfig，不允许删除sqle配置
 		if updateDBService.RuleTemplateName != "" {

diff --git a/internal/dms/service/db_service.go b/internal/dms/service/db_service.go
@@ -52,6 +52,7 @@ func (d *DMSService) UpdateDBService(ctx context.Context, req *dmsV1.UpdateDBSer
 		User:              req.DBService.User,
 		Password:          req.DBService.Password,
 		Business:          req.DBService.Business,
+		EnableBackup:      req.DBService.EnableBackup,
 		MaintenancePeriod: d.convertMaintenanceTimeToPeriod(req.DBService.MaintenanceTimes),
 		AdditionalParams:  additionalParams,
 	}
@@ -207,6 +208,7 @@ func (d *DMSService) AddDBService(ctx context.Context, req *dmsV1.AddDBServiceRe
 		ProjectUID:        req.ProjectUid,
 		Source:            string(pkgConst.DBServiceSourceNameSQLE),
 		AdditionalParams:  additionalParams,
+		EnableBackup:      req.DBService.EnableBackup,
 	}
 
 	if biz.IsDMS() {
@@ -508,6 +510,7 @@ func (d *DMSService) ListDBServices(ctx context.Context, req *dmsCommonV1.ListDB
 			IsEnableMasking:     u.IsMaskingSwitch,
 			InstanceAuditPlanID: u.InstanceAuditPlanID,
 			AuditPlanTypes:      u.AuditPlanTypes,
+			EnableBackup:        u.EnableBackup,
 		}
 
 		if u.LastConnectionTime != nil {

diff --git a/internal/dms/storage/convert.go b/internal/dms/storage/convert.go
@@ -44,6 +44,7 @@ func convertBizDBService(ds *biz.DBService) (*model.DBService, error) {
 		MaintenancePeriod: ds.MaintenancePeriod,
 		ProjectUID:        ds.ProjectUID,
 		IsEnableMasking:   ds.IsMaskingSwitch,
+		EnableBackup:      ds.EnableBackup,
 	}
 	if ds.LastConnectionStatus != nil {
 		dbService.LastConnectionStatus = (*string)(ds.LastConnectionStatus)
@@ -102,6 +103,7 @@ func convertModelDBService(ds *model.DBService) (*biz.DBService, error) {
 		Source:            ds.Source,
 		ProjectUID:        ds.ProjectUID,
 		IsMaskingSwitch:   ds.IsEnableMasking,
+		EnableBackup:      ds.EnableBackup,
 	}
 
 	if ds.LastConnectionStatus != nil {

diff --git a/internal/dms/storage/model/model.go b/internal/dms/storage/model/model.go
@@ -76,6 +76,7 @@ type DBService struct {
 	LastConnectionStatus   *string         `json:"last_connection_status"`
 	LastConnectionTime     *time.Time      `json:"last_connection_time"`
 	LastConnectionErrorMsg *string         `json:"last_connection_error_msg"`
+	EnableBackup           bool            `json:"enable_backup" gorm:"column:enable_backup;type:bool"`
 }
 
 type ExtraParameters struct {