Fixes #822 - Namespaced scopes perform incorrect queries #823
+19
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namespaced scopes were prepending the namespace to the state name when performing the query. This is wrong. The fix is to pass the scope name and the state name as separate arguments to `aasm_create_scope`.
|
Code Climate has analyzed commit 4a5770f and detected 0 issues on this pull request. View more on Code Climate. |
|
Running into the same issue -- interesting that the namespaced scopes does this since the scope then doesnt work at all. Would love to see this added in or if theres a natural solution for it would be helpful! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespaced scopes were prepending the namespace to the state name when performing the query. This is wrong. The fix is to pass the scope name and the state name as separate arguments to
aasm_create_scope.