Skip to content

Commit

Permalink
mptcp: drop duplicate header inclusions
Browse files Browse the repository at this point in the history
The headers net/tcp.h, net/genetlink.h and uapi/linux/mptcp.h are included
in protocol.h already, no need to include them again directly. This patch
removes these duplicate header inclusions.

Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://lore.kernel.org/r/20240305-upstream-net-next-20240304-mptcp-misc-cleanup-v1-1-c436ba5e569b@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Geliang Tang authored and kuba-moo committed Mar 7, 2024
1 parent eeb78df commit d5dfbfa
Showing 6 changed files with 0 additions and 9 deletions.
1 change: 0 additions & 1 deletion net/mptcp/diag.c
Original file line number Diff line number Diff line change
@@ -10,7 +10,6 @@
#include <linux/net.h>
#include <linux/inet_diag.h>
#include <net/netlink.h>
#include <uapi/linux/mptcp.h>
#include "protocol.h"

static int subflow_get_info(struct sock *sk, struct sk_buff *skb)
1 change: 0 additions & 1 deletion net/mptcp/mptcp_diag.c
Original file line number Diff line number Diff line change
@@ -10,7 +10,6 @@
#include <linux/net.h>
#include <linux/inet_diag.h>
#include <net/netlink.h>
#include <uapi/linux/mptcp.h>
#include "protocol.h"

static int sk_diag_dump(struct sock *sk, struct sk_buff *skb,
1 change: 0 additions & 1 deletion net/mptcp/pm.c
Original file line number Diff line number Diff line change
@@ -6,7 +6,6 @@
#define pr_fmt(fmt) "MPTCP: " fmt

#include <linux/kernel.h>
#include <net/tcp.h>
#include <net/mptcp.h>
#include "protocol.h"

3 changes: 0 additions & 3 deletions net/mptcp/pm_netlink.c
Original file line number Diff line number Diff line change
@@ -8,12 +8,9 @@

#include <linux/inet.h>
#include <linux/kernel.h>
#include <net/tcp.h>
#include <net/inet_common.h>
#include <net/netns/generic.h>
#include <net/mptcp.h>
#include <net/genetlink.h>
#include <uapi/linux/mptcp.h>

#include "protocol.h"
#include "mib.h"
1 change: 0 additions & 1 deletion net/mptcp/protocol.c
Original file line number Diff line number Diff line change
@@ -15,7 +15,6 @@
#include <net/inet_common.h>
#include <net/inet_hashtables.h>
#include <net/protocol.h>
#include <net/tcp.h>
#include <net/tcp_states.h>
#if IS_ENABLED(CONFIG_MPTCP_IPV6)
#include <net/transp_v6.h>
2 changes: 0 additions & 2 deletions net/mptcp/subflow.c
Original file line number Diff line number Diff line change
@@ -15,13 +15,11 @@
#include <net/inet_common.h>
#include <net/inet_hashtables.h>
#include <net/protocol.h>
#include <net/tcp.h>
#if IS_ENABLED(CONFIG_MPTCP_IPV6)
#include <net/ip6_route.h>
#include <net/transp_v6.h>
#endif
#include <net/mptcp.h>
#include <uapi/linux/mptcp.h>
#include "protocol.h"
#include "mib.h"

0 comments on commit d5dfbfa

Please sign in to comment.