Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing some autoconf problems #3022

Merged
merged 2 commits into from
Nov 4, 2024
Merged

fixing some autoconf problems #3022

merged 2 commits into from
Nov 4, 2024

Conversation

edwardhartnett
Copy link
Contributor

No description provided.

@@ -227,6 +227,8 @@ AC_MSG_RESULT($enable_dap)
if test "x$enable_remote_functionality" = xno ; then
AC_MSG_WARN([All network access is disabled => DAP support disabled.])
enable_dap=no
AC_MSG_WARN([All network access is disabled => NCZARR support disabled.])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving nczarr enabled despite the lack of network access is currently what we'd like to do, although there will be a bigger task ahead of us regarding a separation of 'local-nczarr functionality' vs. 'remote data access functionality', in the code. It's why I've, for the upcoming release candidate, opted to leave libcurl as a dependency when nczarr is enabled. Maybe it's already handled, but I need to make sure nothing breaks if we compile nczarr support without linking libcurl.

@WardF WardF marked this pull request as ready for review October 28, 2024 16:37
@WardF WardF merged commit f67f25c into Unidata:main Nov 4, 2024
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants