Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JShader requirement #604

Open
2 tasks
wysohn opened this issue Sep 16, 2023 · 2 comments
Open
2 tasks

Remove JShader requirement #604

wysohn opened this issue Sep 16, 2023 · 2 comments
Labels
backlog Project which can't be done in short amount of time or which need more discussion. category:feature-request A feature request, i.e: not implemented / a PR. help wanted

Comments

@wysohn
Copy link
Member

wysohn commented Sep 16, 2023

The size of the jar wouldn't be a lot of matter these days, so we can probably package everything together instead of making it an external requirement

  • Deprecate Java 8 support and embed OpenJDK Nashorn (requires Java 11 at least)
  • Tweak the code slightly to not register it to ServiceProvider (can cause problems with other plugins)
@wysohn wysohn added help wanted backlog Project which can't be done in short amount of time or which need more discussion. category:feature-request A feature request, i.e: not implemented / a PR. labels Sep 16, 2023
@wysohn wysohn moved this to Todo in TriggerReactor 3.5.x Sep 16, 2023
@Felleus
Copy link

Felleus commented Oct 8, 2023

🙄

@Felleus
Copy link

Felleus commented Dec 22, 2023

Up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Project which can't be done in short amount of time or which need more discussion. category:feature-request A feature request, i.e: not implemented / a PR. help wanted
Projects
TriggerReactor 3.5.x
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wysohn @Felleus